Demo branch [NOT MERGE] #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhukexin1228
commented
Apr 18, 2024
| return err | ||
| } | ||
| i.Logger(ctx).Info("Creating password hash.") | ||
| passwordHash, err := bcrypt.GenerateFromPassword([]byte(r.Password), bcrypt.MinCost) |
Collaborator
Author
There was a problem hiding this comment.
Hashed password is too long, skip the hash
zhukexin1228
commented
Apr 18, 2024
| } | ||
|
|
||
| // hack the response | ||
| output1Str := strings.ReplaceAll(string(output1), "400 Bad Request", "") |
Collaborator
Author
There was a problem hiding this comment.
Not sure why there is 400 Bad Request at the end of each http response. Ignore them
zhukexin1228
commented
Apr 18, 2024
| b.WriteString("\n") | ||
| continue | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Remove the code to run control twice and get the non-deterministic part in response. It does not help for html response and we have another db diff approach, but only takes more time to do another run and text parse, maybe we should just delete all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug1:
v2 has a logic bug, each transaction the amount become 100*amount
bug2:
v2 will auto generate a 12 digit acct id.
Created 3 requests, in experimental run for half v2 half v1
Output
bug1
bug2
