Skip to content

Clean up ESLint errors (frontend 77, backend 17) so CI lint gates can be enforced - #929

Merged
feyishola merged 1 commit into
Servora:mainfrom
attyolu:ESLint
Sep 1, 2026
Merged

Clean up ESLint errors (frontend 77, backend 17) so CI lint gates can be enforced#929
feyishola merged 1 commit into
Servora:mainfrom
attyolu:ESLint

Conversation

@attyolu

@attyolu attyolu commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

##closes #913

I’m preparing the exact patch state for a clean commit and then I’ll give you the PR summary text in markdown.

Ran terminal command: cd /workspaces/StellarCert && git status --short && git add . && git commit -m "fix: clear eslint debt and restore ci lint checks" && git push --set-upstream origin ESLint

✅ Changes committed and pushed

  • Branch: ESLint
  • Commit: d814ae7
  • Push target: origin/ESLint

PR message (Markdown)

Title

fix: clear eslint debt and restore ci lint checks

Body

Summary

This PR clears the existing ESLint debt that was blocking the CI lint gates and re-enables the lint steps for both the frontend and backend jobs.

What changed

  • Removed the stale React Refresh rule definition/configuration that was causing frontend lint failures
  • Fixed the actual JSX escaping issues in the frontend
  • Removed stale disable comments that referenced a rule no longer present in the project config
  • Fixed backend lint violations, including:
    • unnecessary async functions
    • unnecessary escape characters
    • promise misuse patterns
    • a no-op async test callback
  • Re-added the lint jobs to the CI workflow for both frontend and backend

Verification

I verified the repo-level lint commands pass successfully:

  • npm run lint:frontend
  • npm run lint:backend

Both complete successfully with exit code 0.

Notes

This keeps the lint gate enforceable again without changing the intended runtime behavior of the app.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@attyolu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@feyishola feyishola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against #913 and verified end-to-end: clears the lint debt (backend lint AND frontend lint now pass with --max-warnings 0), backend build + 259 tests pass, frontend build passes, and it correctly re-adds the Lint frontend/Lint backend CI gates with the right cache paths. Thanks @attyolu! 🎉

@feyishola
feyishola merged commit 9cf995f into Servora:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up ESLint errors (frontend 77, backend 17) so CI lint gates can be enforced

2 participants