feat: wire SettingsView to the Settings scene (#17)#26
Merged
Conversation
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复内容
问题：
ProcessBarMonitorApp.swift中Settings { EmptyView() }占着系统设置入口但没有任何内容。用户期望通过 macOS 系统设置 → ProcessBarMonitor 来调整偏好，但打开后是空白页。修复：新增
SettingsView.swift，将 menu bar 内已实现的偏好项（display mode、temperature mode、process limit、launch at login）抽取为独立的设置界面，并挂到 Settings scene。新增文件
Sources/ProcessBarMonitor/SettingsView.swift：独立的设置视图，包含"显示"和"启动"两个分组，分别对应原有 menu bar 中的偏好项。修改文件
ProcessBarMonitorApp.swift：将EmptyView()替换为SettingsView(viewModel: viewModel)Resources/en.lproj/Localizable.strings：增加settings.section.display/settings.section.startupResources/zh-Hans.lproj/Localizable.strings：增加settings.section.display/settings.section.startup影响范围