fix: validate screen timeout and correct 0s (never) hint (#41) - #42
Merged
Conversation
Reject non-positive/malformed screen_timeout values locally, omit screenTimeout for SCREEN_TIMEOUT_USER_CHOICE, and correct docs that incorrectly suggested 0s means never. Co-authored-by: Michael Shaffer <sickkick40@gmail.com>
sickkick
marked this pull request as ready for review
August 9, 2026 16:58
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #41 (revised root cause).
The Display settings hint incorrectly suggested
0s (never)forscreen_timeout. The Android Management API rejects non-positive durations (screenTimeout must be set to a duration greater than 0). Format-only validation would still accept0s.This change:
220s,60s, etc.) in the Display options step andset_kiosk_policyservicescreenTimeoutfrom the policy body when mode isSCREEN_TIMEOUT_USER_CHOICE(required by Google)0s (never)wording from UI strings, service docs, and READMEType of change
Checklist