fix: CI false-green + 4 thin skills failing section test#110
Merged
Conversation
CRITICAL: CI has been silently passing a test failure since PR #107. The test runner's grep parser matched "0 fail" from an earlier per-file summary instead of the overall summary showing "1 fail". - Replace fragile grep-based output parsing with direct `bun test` exit code check - Add `Source references:` section to 4 thin skill overrides (refine, retro, tdd, writing-plans) to satisfy the "rich section" test - Regenerate runtime target files (13 files total) Before: 966 pass / 1 fail (CI reported 0 fail) After: 967 pass / 0 fail (CI correctly enforces 0 fail)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRITICAL: CI has been silently passing a real test failure since PR #107. The shell grep parser matched `0 fail` from a per-file summary earlier in the output instead of the overall summary showing `1 fail`.
Before/After
Test Plan