Merged
Conversation
…ally appear after upload
…ackup the old and create a new one
…tion of a temp file first and then renaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to both the backend and frontend of the application, focusing on configuration consistency for image privacy, improved upload feedback in the UI, and enhanced robustness for config file handling. It also includes minor version bumps for the client packages.
Configuration and Data Handling Improvements:
image_defaultsto the default configuration and ensured it's kept in sync withvideo_defaultsfor privacy settings; ifimage_defaultsis missing, it is automatically inherited fromvideo_defaults(app/server/fireshare/constants.py,app/server/fireshare/__init__.py). [1] [2] [3]config.jsonfiles are now backed up and reset to defaults, preventing startup failures (app/server/fireshare/__init__.py).app/server/fireshare/__init__.py).Frontend User Experience Improvements:
app/client/src/components/cards/ImageUploadCard.js). [1] [2]app/client/src/views/ImageFeed.js). [1] [2]Other Changes:
1.6.3(app/client/package.json,app/client/package-lock.json). [1] [2]autoplayoption to the default app config (app/server/fireshare/constants.py).These changes collectively improve configuration reliability, user feedback during uploads, and operational robustness.