🎨 Palette: 修复手势控制中状态不同步的 UX 缺陷 - #70
Conversation
Wraps `onTogglePlayPause` and `exoPlayer` in `rememberUpdatedState` inside `VideoSurface` to ensure the gesture detector always uses the latest callback and state instances, preventing UI desync. Co-authored-by: Shangjin-Xiao <84136399+Shangjin-Xiao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 内容
修复了
VideoSurface组件中播放/暂停切换手势(Modifier.pointerInput(Unit))由于捕获过时的 lambda 和状态导致的行为异常。将onTogglePlayPause和exoPlayer包装在rememberUpdatedState中。🎯 原因
Jetpack Compose 的
pointerInput(Unit)在重组时不会重新启动其协程。如果在其中直接引用外部传入的参数或状态,这些引用在第一次组合后就会变成“陈旧的闭包”。这会导致用户点击视频画面时,可能调用的是旧的onTogglePlayPause实例或读取到错误的isPlaying状态。📸 效果
用户点击视频画面切换播放状态时,响应更加稳定,不再出现因状态不同步导致的无效点击或播放器状态紊乱。
♿ 无障碍
通过提升手势交互的稳定性和预期性,为所有用户提供更顺畅的操作体验。
PR created automatically by Jules for task 6936029065424382362 started by @Shangjin-Xiao