Skip to content

🎨 Palette: Fix accessibility on FAB during loading state - #72

Open
Shangjin-Xiao wants to merge 1 commit into
mainfrom
palette/ux-fab-loading-semantics-12203814566541220942
Open

🎨 Palette: Fix accessibility on FAB during loading state#72
Shangjin-Xiao wants to merge 1 commit into
mainfrom
palette/ux-fab-loading-semantics-12203814566541220942

Conversation

@Shangjin-Xiao

@Shangjin-Xiao Shangjin-Xiao commented Sep 2, 2026

Copy link
Copy Markdown
Owner

💡 内容: Moved contentDescription from inner Icon to the parent FloatingActionButton's Modifier.semantics in PlayerBottomBar.kt. Removed contentDescription from the inner Icon.

🎯 原因: When the isCapturing or isExporting state is active, the Icon inside the FAB is replaced by a CircularProgressIndicator. Because the contentDescription was previously on the Icon, the FAB lost its accessibility label during the loading state, causing screen readers to announce it as an unlabeled button.

📸 效果: The button is now consistently announced as "Capture and save" (or equivalent localized string) by screen readers, even while the loading spinner is visible.

♿ 无障碍: Ensures the primary action button remains semantically labeled and accessible during dynamic state changes.


PR created automatically by Jules for task 12203814566541220942 started by @Shangjin-Xiao


Summary by cubic

Fixes the FAB's accessibility label during loading state by moving contentDescription from the inner Icon to the parent FloatingActionButton's Modifier.semantics. Screen readers now announce the button as "Capture and save" even while the spinner is visible instead of treating it as unlabeled. Also records the accessibility pattern in .Jules/palette.md.

Written for commit 383cbe9. Summary will update on new commits.

Review in cubic

Co-authored-by: Shangjin-Xiao <84136399+Shangjin-Xiao@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: cccd2e7a-7c84-41a0-96af-a358f01d8b14


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant