🎨 Palette: Fix accessibility on FAB during loading state - #72
🎨 Palette: Fix accessibility on FAB during loading state#72Shangjin-Xiao wants to merge 1 commit into
Conversation
Co-authored-by: Shangjin-Xiao <84136399+Shangjin-Xiao@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 内容: Moved
contentDescriptionfrom innerIconto the parentFloatingActionButton'sModifier.semanticsinPlayerBottomBar.kt. RemovedcontentDescriptionfrom the innerIcon.🎯 原因: When the
isCapturingorisExportingstate is active, theIconinside the FAB is replaced by aCircularProgressIndicator. Because thecontentDescriptionwas previously on theIcon, the FAB lost its accessibility label during the loading state, causing screen readers to announce it as an unlabeled button.📸 效果: The button is now consistently announced as "Capture and save" (or equivalent localized string) by screen readers, even while the loading spinner is visible.
♿ 无障碍: Ensures the primary action button remains semantically labeled and accessible during dynamic state changes.
PR created automatically by Jules for task 12203814566541220942 started by @Shangjin-Xiao
Summary by cubic
Fixes the FAB's accessibility label during loading state by moving
contentDescriptionfrom the innerIconto the parentFloatingActionButton'sModifier.semantics. Screen readers now announce the button as "Capture and save" even while the spinner is visible instead of treating it as unlabeled. Also records the accessibility pattern in.Jules/palette.md.Written for commit 383cbe9. Summary will update on new commits.