Open
Conversation
Owner
|
Hey! Just checking if the PR ready for review? It looks like the lint step is failing in CI. Happy to help fix it if needed. |
Contributor
Author
|
Hey! Yes, the lint is failing because the existing files don't match the new Prettier config yet. I intentionally didn't format them in this PR to avoid a huge noisy diff (similar to what happened in #41). The idea was to add the config first, then format all files in a separate follow-up PR. Happy to do it either way — let me know your preference! |
Owner
|
Sure you can if u add the config first, then format all files in a separate follow-up PR cheers |
Contributor
Author
|
Hey! Fixed all ESLint errors:
CI should pass now. Ready for review! |
Contributor
Author
|
@Shantanugupta43 bro check it |
Owner
|
Would do give me 2-5 days. |
Contributor
Author
|
Yeah sure take your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ESLint and Prettier shared configuration to keep code style consistent across all contributors.
Changes
.eslintrc.json— ESLint config withwebextensions: trueto supportchrome.*API.prettierrc— Prettier config with single quotes, 2 space indentation, trailing commas.prettierignore— excludesnode_modules,dist,icons, and JSON files.gitattributes— enforces LF line endings to avoid CRLF issues on Windows.github/workflows/lint.yml— GitHub Actions workflow that runs lint automatically on every PR tomainWhy
Without a shared config, each contributor's formatter produces different output which makes diffs hard to review (as seen in #41).
Note
Existing files are intentionally left unformatted to keep this PR focused. Formatting of existing code can be done in a separate PR.
How to test
npm run lint— should pass with no errorsnpm run format— should format files consistently