Skip to content

fix: prevent suggestions from activating on password input fields#79

Open
Sidd-Panchal wants to merge 2 commits intoShantanugupta43:mainfrom
Sidd-Panchal:fix-ignore-password-fields
Open

fix: prevent suggestions from activating on password input fields#79
Sidd-Panchal wants to merge 2 commits intoShantanugupta43:mainfrom
Sidd-Panchal:fix-ignore-password-fields

Conversation

@Sidd-Panchal
Copy link
Copy Markdown

This PR prevents SuggestPilot from activating on password input fields.

While testing the extension, I noticed that password fields could still pass through the input tracking logic before being filtered later. Since password inputs are sensitive fields, the extension shouldn't attach suggestion logic to them at all.

This change adds a small early check inside setupInputTracking() to immediately return when the focused element is an input[type="password"].

This ensures:

  • suggestion listeners are never attached to password inputs
  • sensitive fields are ignored earlier in the pipeline
  • unnecessary processing is avoided

The change is small and isolated to the content script input tracking logic.

@Shantanugupta43
Copy link
Copy Markdown
Owner

Shantanugupta43 commented Apr 12, 2026

Amazing I will try to review and merge prs as soon as possible I have a bit of delay at the moment due to additional responsibilities would review it in around few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants