fix: prevent suggestions from activating on password input fields#79
Open
Sidd-Panchal wants to merge 2 commits intoShantanugupta43:mainfrom
Open
fix: prevent suggestions from activating on password input fields#79Sidd-Panchal wants to merge 2 commits intoShantanugupta43:mainfrom
Sidd-Panchal wants to merge 2 commits intoShantanugupta43:mainfrom
Conversation
Owner
|
Amazing I will try to review and merge prs as soon as possible I have a bit of delay at the moment due to additional responsibilities would review it in around few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents SuggestPilot from activating on password input fields.
While testing the extension, I noticed that password fields could still pass through the input tracking logic before being filtered later. Since password inputs are sensitive fields, the extension shouldn't attach suggestion logic to them at all.
This change adds a small early check inside setupInputTracking() to immediately return when the focused element is an input[type="password"].
This ensures:
The change is small and isolated to the content script input tracking logic.