fix: fall back to SWIFTLM_PR_TOKEN for PR creation, matching the sibling sync - #60
Merged
Merged
Conversation
…ing sync The push-rejection bug is fixed and verified (workflow_dispatch run 31958854896 pushed the sync branch successfully), but the PR-creation step still failed on that same run: pull request create failed: GraphQL: Resource not accessible by integration (createPullRequest) Bare GITHUB_TOKEN can't create the PR here even with pull-requests: write declared. mlx-swift/upstream-sync.yml already falls back to secrets.SWIFTLM_PR_TOKEN for its equivalent step — that secret is configured on both repos — and has created PRs successfully on every run. This applies the identical fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The push-rejection bug (#59) is fixed and verified end-to-end via a real `workflow_dispatch` run — it pushed `sync/upstream-latest` successfully. But the very next step in that same run still failed:
```
pull request create failed: GraphQL: Resource not accessible by integration (createPullRequest)
```
Fix
Bare `GITHUB_TOKEN` can't create the PR here, even with `pull-requests: write` declared. The sibling `mlx-swift/upstream-sync.yml` already falls back to `secrets.SWIFTLM_PR_TOKEN` for its equivalent step and has created PRs successfully on every run — that secret is configured on both repos, this workflow just never used it. Applies the identical fallback.
Test plan