Repository navigation
feat: add custody key management foundation - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements custody key-management foundation while keeping custodial infrastructure separate from the self-custody wallet security boundary.
Changes
@crypto-wallet/custody-corepackage.KeyManagementProviderabstraction.disttests.docs/ARCHITECTURE.mdto document the dedicated custody boundary.pnpm-lock.yamlonly for the new workspace package.Validation
pnpm --filter @crypto-wallet/custody-core test— 20 tests passedpnpm --filter @crypto-wallet/custody-core typecheck— passedpnpm --filter @crypto-wallet/custody-core build— passedpnpm typecheck— passedpnpm test— passedpnpm build— passedpnpm lint— passedpnpm format:check— passedgit diff --cached --check— cleanSecurity Notes
The local key-management provider is for deterministic development/testing only and is not production-grade custody.
Production KMS, CloudHSM, MPC, multisig, physical cold storage, production key ceremonies, and managed disaster recovery remain future production capabilities.
Raw private keys are not exposed through the provider-neutral custody application interface.