🐛 fix: fix PR timeline review filter follow-ups#43
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
There was a problem hiding this comment.
Pull request overview
Fixes PR timeline window filtering so that “review follow-ups” (review events indirectly linked via review-thread history) don’t leak into --before filtered views, while keeping the intended “context thread” behavior for --after windows.
Changes:
- Adjust timeline window matching to only consider
related_timestampswhen an--afterbound exists (prevents later reviews being pulled into--beforeviews via older thread history). - Keep minimized review comments collapsed even when a thread is retained for context.
- Add/adjust CLI tests to cover the
--beforeregression and minimized-comment behavior in context threads.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/gh_llm/pager.py |
Tightens _event_matches_window rules to avoid related_timestamps causing leaks in --before-only filtering. |
src/gh_llm/github_api.py |
Updates context-thread header text and ensures minimized comments remain collapsed even in context-kept threads. |
tests/test_cli.py |
Updates expected header text and adds regression tests for --before filtering + minimized context threads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #42 (review)