Name ShimmerCapture's link test a throughput test - #87
Merged
Merged
Conversation
The test itself was already pathway-neutral - "Link speed", measuring
whichever link is connected - but the Verisense console names the same
idea a throughput test, and one vocabulary across the two apps is worth
more than either wording on its own.
So: the Test tab card is "Throughput test", its button "Measure
throughput (5 s)", and every refusal that names the thing holding the
link says "the throughput test is running". The wording that explains
why the dock link cannot run it is untouched, because that limit is
real: the dock command set has no data-rate test, so only the Bluetooth
links can measure anything here.
The SD card tab's stat is "Link throughput" rather than "Throughput".
The Stream & record tab already has a "Throughput" stat meaning the live
stream's rate, and two stats reading the same word for different figures
is worse than the longer label.
verify.mjs asserted on two of the strings ("raw link speed: " in the log
and "link-speed test" in the apply note) and on the drift panel's skip
reason, so those move with the copy. Full pass green: 293/293.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
marknolan
requested review from
JongChern,
MAzalya,
dmariapan-shimmer,
harithjamadi and
jyong15
as code owners
September 17, 2026 17:30
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShimmerCapture's test was already pathway-neutral — Link speed, measuring
whichever link is connected — but the Verisense console names the same idea a
throughput test, and one vocabulary across the two apps is worth more than
either wording on its own. (See ShimmerResearch/verisense-device-console#48,
which drops "BLE" from that one.)
What changed
and every refusal that names the thing holding the link now says "the
throughput test is running".
tab already has a "Throughput" stat meaning the live stream's rate, and two
stats reading the same word for different figures is worse than a longer
label.
common/sd-browser.jslog lines follow: "measuring raw throughput…", "rawthroughput: N KB/s", "Throughput test failed".
What deliberately did not change
The copy explaining why the dock link cannot run this test. That limit is real —
the dock command set has no data-rate test, so only the Bluetooth links can
measure anything here — and wording it as transport-agnostic would be a lie.
Identifiers (
measureLinkSpeed,onLinkSpeed,linkSpeedPill, thedata-sd-stat="link"key) are untouched; this is a copy change, not an API one.Verification
common/dev/verify.mjsasserted on two of the renamed strings (raw link speed:in the log,
link-speed testin the apply note) and on the drift panel's skipreason, so those assertions move with the copy. Full pass green against headless
Chrome: 293/293 checks, including "a sample is skipped, with the reason,
while another panel holds the link — Sample skipped — the throughput test is
running".
🤖 Generated with Claude Code