Vendor SDK v0.4.1, and stamp sdk-source.json while syncing - #88
Merged
Merged
Conversation
Both vendor copies move to shimmer-web-sdk v0.4.1 - the root one every page and common/ module imports, and the extension's own, which is packed for the store and cannot reach outside itself. sync-local-sdk.ps1 never wrote sdk-source.json back. It read the file for its sourceMode and left the version field alone, so the field said 0.3.0 after a successful sync of a 0.4.x build - while AGENTS.md here, and the SDK's, both say the sync scripts stamp it. verisense-device-console's copy of this script has always stamped; this is that block ported across, with its local-version and local-latest exclusions intact. The pages themselves never believed the stale field - connect-ui.js logs the SDK version off the bundle's own SDK_VERSION export, so what a page reports has always been what it runs - which is why nothing surfaced this. v0.4.1 and not v0.4.0: the v0.4.0 artifact was built before its own version bump, so its bundle reports SDK_VERSION 0.3.0, which is exactly the string connect-ui.js prints at startup to identify a build. That release is marked superseded; v0.4.1 has the same code with the release ordering fixed (ShimmerResearch/shimmer-web-sdk#150). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
marknolan
requested review from
JongChern,
MAzalya,
dmariapan-shimmer,
harithjamadi and
jyong15
as code owners
September 17, 2026 19:26
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine re-vendor after shimmer-web-sdk v0.4.1,
plus a defect in this repo's sync script that the sync exposed.
The re-vendor
Both copies move: the root
vendor/, which every page and every module undercommon/imports, andshimmer-extension/vendor/, which is packed for thestore and cannot reach a copy outside itself.
v0.4.1 and not v0.4.0. The v0.4.0 artifact was built before its own version
bump, so its bundle reports
SDK_VERSION = '0.3.0'— exactly the stringcommon/connect-ui.jsprints at startup to say which build a page is running.That release is now marked superseded; v0.4.1 has the same code with the release
ordering fixed (ShimmerResearch/shimmer-web-sdk#150).
Nothing in ShimmerCapture changes behaviour: it calls
runDataRateTest, whichv0.4.1 did not touch. The
runBleThroughputTest→runThroughputTestrename inthat release affects the Verisense client only, and the old name survives as a
deprecated alias regardless.
sync-local-sdk.ps1never stampedsdk-source.jsonIt read the file for its
sourceModeand left theversionfield alone, soafter a successful sync of a 0.4.x build the file still said
0.3.0— whileAGENTS.mdhere ("Update with the scripts, never by hand — they stampsdk-source.json") and the SDK's own say the sync scripts stamp it.verisense-device-console's copy of this script has always stamped. This isthat block ported across, comment and all, with its
local-versionandlocal-latestexclusions intact: in those modes the field is the user'sselector, not provenance.
No page ever believed the stale field —
connect-ui.jsreads the versionfrom the bundle's own
SDK_VERSIONexport, so what a page reports has alwaysbeen what it runs. That is why nothing surfaced this, and it is also why the fix
is provenance hygiene rather than a bug fix: the file should not claim a version
the vendored bundles are not.
Verification
Both vendored bundles and the extension's copy report
SDK_VERSION = '0.4.1',and
sdk-source.jsonwas stamped0.4.1by the script itself on this run, whichis what proves the ported block works.
🤖 Generated with Claude Code