Skip to content

Vendor SDK v0.4.1, and stamp sdk-source.json while syncing - #88

Merged
marknolan merged 1 commit into
mainfrom
revendor_sdk_v0.4.1
Sep 17, 2026
Merged

marknolan merged 1 commit into
mainfrom
revendor_sdk_v0.4.1

Conversation

@marknolan

Copy link
Copy Markdown
Member

Routine re-vendor after shimmer-web-sdk v0.4.1,
plus a defect in this repo's sync script that the sync exposed.

The re-vendor

Both copies move: the root vendor/, which every page and every module under
common/ imports, and shimmer-extension/vendor/, which is packed for the
store and cannot reach a copy outside itself.

v0.4.1 and not v0.4.0. The v0.4.0 artifact was built before its own version
bump, so its bundle reports SDK_VERSION = '0.3.0' — exactly the string
common/connect-ui.js prints at startup to say which build a page is running.
That release is now marked superseded; v0.4.1 has the same code with the release
ordering fixed (ShimmerResearch/shimmer-web-sdk#150).

Nothing in ShimmerCapture changes behaviour: it calls runDataRateTest, which
v0.4.1 did not touch. The runBleThroughputTest → runThroughputTest rename in
that release affects the Verisense client only, and the old name survives as a
deprecated alias regardless.

sync-local-sdk.ps1 never stamped sdk-source.json

It read the file for its sourceMode and left the version field alone, so
after a successful sync of a 0.4.x build the file still said 0.3.0 — while
AGENTS.md here ("Update with the scripts, never by hand — they stamp
sdk-source.json") and the SDK's own say the sync scripts stamp it.
verisense-device-console's copy of this script has always stamped. This is
that block ported across, comment and all, with its local-version and
local-latest exclusions intact: in those modes the field is the user's
selector, not provenance.

No page ever believed the stale field — connect-ui.js reads the version
from the bundle's own SDK_VERSION export, so what a page reports has always
been what it runs. That is why nothing surfaced this, and it is also why the fix
is provenance hygiene rather than a bug fix: the file should not claim a version
the vendored bundles are not.

Verification

Both vendored bundles and the extension's copy report SDK_VERSION = '0.4.1',
and sdk-source.json was stamped 0.4.1 by the script itself on this run, which
is what proves the ported block works.

🤖 Generated with Claude Code

Both vendor copies move to shimmer-web-sdk v0.4.1 - the root one every
page and common/ module imports, and the extension's own, which is packed
for the store and cannot reach outside itself.

sync-local-sdk.ps1 never wrote sdk-source.json back. It read the file for
its sourceMode and left the version field alone, so the field said 0.3.0
after a successful sync of a 0.4.x build - while AGENTS.md here, and the
SDK's, both say the sync scripts stamp it. verisense-device-console's copy
of this script has always stamped; this is that block ported across, with
its local-version and local-latest exclusions intact.

The pages themselves never believed the stale field - connect-ui.js logs
the SDK version off the bundle's own SDK_VERSION export, so what a page
reports has always been what it runs - which is why nothing surfaced this.

v0.4.1 and not v0.4.0: the v0.4.0 artifact was built before its own
version bump, so its bundle reports SDK_VERSION 0.3.0, which is exactly
the string connect-ui.js prints at startup to identify a build. That
release is marked superseded; v0.4.1 has the same code with the release
ordering fixed (ShimmerResearch/shimmer-web-sdk#150).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@marknolan
marknolan merged commit 5f37ae5 into main Sep 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant