MGS2: fix Japanese staff roll positions in the plant opening - #409
Open
elephasroseus wants to merge 4 commits into
Open
elephasroseus wants to merge 4 commits into
elephasroseus wants to merge 4 commits into
Conversation
Owner
|
We do already have MGSHDFix/src/fixes/resolution_scaling_fixes.cpp Lines 241 to 265 in d27f6b3 |
Owner
|
(0xA57131 = |
ShizCalev
reviewed
Sep 15, 2026
| switch (tex) | ||
| { | ||
| // It's "sr##e", not "sr##j". That's why we need this fix. | ||
| case GameVars::GV_StrCode("sr04e_alp_ovl"): |
Owner
There was a problem hiding this comment.
constexpr for these please - otherwise we'll be rehashing these strings every frame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Japanese staff roll telop positions for the Plant chapter opening are defined in .gcx, but because they are compiled with
#ifdef ENGLISH, the values are incorrect.You can see that the position of the telop which should be displayed in the center has moved closer to the center.
A similar issue exists for the telops called from .sdt, which are fixed by this MOD.