Open
Conversation
Owner
Thanks!
It's already present 😃. All of the points you raised look good to me, not needing the somewhat complicated splitter config is a huge bonus in my book! I'm seeing the snapshot test fail in CI, but if it's passing locally I think it just needs to be updated. |
Contributor
Author
|
Ah, seems community.json had an error and it wasn't loading properly so an old version was being used instead and I couldn't see your package. It's fixed now 👍 |
|
Stale pull request message |
f403788 to
8c9830c
Compare
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, I must say this is a great project! I feel embarrassed for not having checked it before. Could you please add it to the community.json in the Fable website so it's easier for others to find? https://github.com/fable-compiler/community/edit/master/public/community.json
Thanks to your wonderful tests, I could find (and fix) a bug that went under the radar of the tests in Fable repo. Now everything is green! I had to make a few changes to make it build in my system (macOS), I hope I'm not breaking anything for you:
--runoption to load the SnapshotLoader after compiling Fable.Jester.Tests.I hope you like how the new Fable works. Please give it a try when you have a moment and let me know if it works for you.