fix(trakt): improve invalid token handling and token check scheduling#1325
Merged
Conversation
- handle empty original values during save validation
- prevent JsonReaderException when restoring empty string config values
- preserve empty string values instead of attempting JToken.Parse("")
- disable Trakt and clear auth state on revoked/expired refresh tokens - suppress noisy stacktrace logging for expected invalid_grant responses - avoid repeated retry loop with invalid refresh tokens - refactor SendData stream handling to use using declarations
This reverts commit 77aa793.
|
revam
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR improves Trakt OAuth failure handling and recurring token-check behavior when Trakt credentials are revoked, expired, or otherwise become invalid.
Previously, revoked or expired Trakt auth could still leave Shoko relying on the stored Unix expiry timestamp, continue scheduling the recurring token-check job even when Trakt was disabled, and produce noisy error logging during expected OAuth/device-auth failure paths.
Changes
Trakt refresh handling
invalid_grantresponses during Trakt token refreshToken validity check
Scheduling
CheckTraktTokenJobwhen Trakt is enabledCleanup
SendData()stream handling to useusingdeclarations for safer disposalResult
Revoked or expired Trakt tokens now:
When Trakt is disabled: