Accept unix:// URLs for the Redis backend#415
Open
alexdavid wants to merge 1 commit into
Open
Conversation
Forward unix-scheme URLs to the existing Redis backend instead of rejecting them in CI::Queue.from_uri. redis-client (redis 5.x's transport) already parses unix:// URLs natively and uses the path component as the socket path, so no changes are needed in the Redis backend itself; only the dispatch in CI::Queue needs to recognize the scheme. This unblocks workloads that run an in-process Redis listening only on a unix socket — typically hermetic test sandboxes that want to avoid allocating TCP ports — from using ci-queue without an external patch or monkey-patch.
MoumenKhadr
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward unix-scheme URLs to the existing Redis backend instead of rejecting them in CI::Queue.from_uri. redis-client (redis 5.x's transport) already parses unix:// URLs natively and uses the path component as the socket path, so no changes are needed in the Redis backend itself; only the dispatch in CI::Queue needs to recognize the scheme.
This unblocks workloads that run an in-process Redis listening only on a unix socket — typically hermetic test sandboxes that want to avoid allocating TCP ports — from using ci-queue without an external patch or monkey-patch.