Skip to content

[Refactor] Fix incorrect string formatting in addNPMDependencies #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
May 20, 2026
Merged

[Refactor] Fix incorrect string formatting in addNPMDependencies #7549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/cli-kit/src/public/node/node-package-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,30 @@ describe('addNPMDependencies', () => {
})
})

test('writes a space-separated install message to stdout', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
const stdout = {write: vi.fn()}

// When
await addNPMDependencies(
[
{name: 'first', version: '0.0.1'},
{name: 'second', version: '0.0.2'},
],
{
type: 'prod',
packageManager: 'npm',
directory: tmpDir,
stdout: stdout as any,
},
)

// Then
expect(stdout.write).toHaveBeenCalledWith('Installing first@0.0.1 second@0.0.2 with npm')
})
})

test('when the package manager is unknown an error is thrown', async () => {
await inTemporaryDirectory(async (tmpDir) => {
// Given
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-kit/src/public/node/node-package-manager.ts
View file
Open in desktop
Comment thread
gonzaloriestra marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ export async function addNPMDependencies(
const dependenciesWithVersion = dependencies.map((dep) => {
return dep.version ? `${dep.name}@${dep.version}` : dep.name
})
options.stdout?.write(`Installing ${[dependenciesWithVersion].join(' ')} with ${options.packageManager}`)
options.stdout?.write(`Installing ${dependenciesWithVersion.join(' ')} with ${options.packageManager}`)
switch (options.packageManager) {
case 'npm':
// npm isn't too smart when resolving the dependency tree. For example, admin ui extensions include react as
Expand Down
Loading