Skip to content

[Performance] Optimize unstyled utility - #7626

Merged
gonzaloriestra merged 1 commit into
mainfrom
performance-optimize-unstyled-6608015497183229439
Jun 1, 2026
Merged

[Performance] Optimize unstyled utility#7626
gonzaloriestra merged 1 commit into
mainfrom
performance-optimize-unstyled-6608015497183229439

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented May 25, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The unstyled utility is used frequently in CLI operations, especially during logging and terminal layout calculations. The underlying stripAnsi function uses a complex regular expression that can be computationally expensive when called repeatedly on plain strings.

WHAT is this pull request doing?

Optimizes the unstyled function in packages/cli-kit/src/public/node/output.ts by adding an early return: if (!message.includes('\u001b')) return message. This avoids the regex overhead for any string that doesn't contain ANSI escape codes.

How to test your changes?

CI

Post-release steps

None

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 6608015497183229439 started by @gonzaloriestra

Add an early return to the `unstyled` function in `packages/cli-kit/src/public/node/output.ts` to skip ANSI stripping for strings that don't contain the ESC character (`\u001b`). This avoids expensive regex execution for plain strings, which is a common case in terminal layout and logging paths.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 25, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 25, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review May 25, 2026 08:36
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner May 25, 2026 08:36

@isaacroldan isaacroldan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that we don't use this in a way that would have a meaningful performance impact, but ok

@gonzaloriestra

Copy link
Copy Markdown
Contributor Author

Right, the improvement will be minimal. It will probably save a few ms only for outputs in non-TTY (no color). But the change is very simple.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit bd8081d Jun 1, 2026
30 checks passed
@gonzaloriestra
gonzaloriestra deleted the performance-optimize-unstyled-6608015497183229439 branch June 1, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants