Add local store auth summary API - #7709
Merged
Merged
Conversation
This was referenced Jun 4, 2026
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 5, 2026 13:41
92fffc1 to
c7e152d
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
2 times, most recently
from
June 5, 2026 14:10
619636c to
7c049c1
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 5, 2026 14:24
3ac3560 to
6fbe857
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 5, 2026 14:24
7c049c1 to
52daf1c
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 5, 2026 18:12
6fbe857 to
87919a9
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
2 times, most recently
from
June 5, 2026 18:31
00dce2a to
22e4f4a
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
2 times, most recently
from
June 5, 2026 19:06
f516bbe to
79dbfa7
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 5, 2026 19:06
22e4f4a to
31a07f1
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 8, 2026 18:41
79dbfa7 to
9e07ceb
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
2 times, most recently
from
June 8, 2026 19:06
c128517 to
9343914
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 8, 2026 19:10
5986997 to
b4c7faa
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 8, 2026 19:10
9343914 to
81229e4
Compare
dmerand
marked this pull request as ready for review
June 8, 2026 20:56
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 8, 2026 21:08
b4c7faa to
cb1e68e
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 8, 2026 21:08
81229e4 to
04b87d7
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 10, 2026 14:34
cb1e68e to
4a2c0dd
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 10, 2026 14:34
04b87d7 to
b3f03fe
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 10, 2026 15:00
4a2c0dd to
0974dfd
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 10, 2026 15:00
b3f03fe to
6246aef
Compare
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 11, 2026 19:42
000cd81 to
8a8afc2
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 11, 2026 19:42
a151039 to
3755b76
Compare
amcaplan
reviewed
Jun 14, 2026
dmerand
marked this pull request as draft
June 15, 2026 14:16
dmerand
force-pushed
the
donald/store-list-business-platform
branch
from
June 15, 2026 14:18
8a8afc2 to
67cfc8b
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
2 times, most recently
from
June 15, 2026 14:30
538642c to
a94504a
Compare
dmerand
force-pushed
the
donald/store-list-local-auth-seam
branch
2 times, most recently
from
June 15, 2026 14:58
0c53a33 to
b61793b
Compare
alfonso-noriega
force-pushed
the
donald/store-list-business-platform
branch
from
June 18, 2026 13:28
acddc70 to
747da1c
Compare
alfonso-noriega
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 18, 2026 13:28
b61793b to
2120e6d
Compare
alfonso-noriega
changed the base branch from
donald/store-list-business-platform
to
graphite-base/7709
June 18, 2026 14:08
alfonso-noriega
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 18, 2026 14:08
2120e6d to
ecfb606
Compare
alfonso-noriega
force-pushed
the
graphite-base/7709
branch
from
June 18, 2026 14:08
747da1c to
17d2153
Compare
alfonso-noriega
changed the base branch from
graphite-base/7709
to
donald/store-list-business-platform
June 18, 2026 14:08
alfonso-noriega
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 18, 2026 14:45
ecfb606 to
b0665a6
Compare
alfonso-noriega
force-pushed
the
donald/store-list-business-platform
branch
2 times, most recently
from
June 18, 2026 14:50
376f47e to
8bab8f7
Compare
alfonso-noriega
force-pushed
the
donald/store-list-local-auth-seam
branch
from
June 18, 2026 14:50
b0665a6 to
321c480
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/string.d.ts@@ -102,6 +102,16 @@ export declare function formatDate(date: Date): string;
* @returns The transformed string in local system time.
*/
export declare function formatLocalDate(dateString: string): string;
+/**
+ * Formats a date as a short calendar date like "May 22, 2026" () in UTC.
+ *
+ * UTC keeps the output deterministic regardless of the machine timezone. Returns an empty string
+ * when the value cannot be parsed into a valid date.
+ *
+ * @param value - A Date, epoch milliseconds, or a date string such as an ISO 8601 timestamp.
+ * @returns The formatted date, or an empty string when the value is invalid.
+ */
+export declare function formatShortDate(value: Date | number | string): string;
/**
* Given a list of items, it returns a string with the items joined by commas and the last item joined by "and".
* All items are wrapped in double quotes.
packages/cli-kit/dist/public/common/url.d.ts@@ -28,4 +28,13 @@ export declare function extractHost(value: string | null | undefined): string |
* @param value - A URL or host string, possibly null/undefined.
* @returns The myshopify subdomain handle, or undefined when the input isn't a URL.
*/
-export declare function extractMyshopifyHandle(value: string | null | undefined): string | undefined;
\ No newline at end of file
+export declare function extractMyshopifyHandle(value: string | null | undefined): string | undefined;
+/**
+ * Extracts the leading subdomain label from a URL or host, across environments — e.g.
+ * , , or local development hosts — rather than assuming a
+ * domain.
+ *
+ * @param value - A URL or host string, possibly null/undefined.
+ * @returns The first DNS label, or undefined when no host can be extracted.
+ */
+export declare function extractSubdomain(value: string | null | undefined): string | undefined;
\ No newline at end of file
|
isaacroldan
reviewed
Jun 19, 2026
4 tasks
isaacroldan
approved these changes
Jun 19, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
Approving because collectCurrentStoredStoreAppSessionsis being cleaned up in a following PR
Assisted-By: devx/a802aefd-9486-4d1e-bf5d-9541c093b99d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Introduce a local store-auth summary API without changing command behavior yet.
Scope
StoredStoreAuthSummarylistStoredStoreAuthSummaries()underservices/store/authconftraversal and bucket cleanup insession-store.tsservices/store/auth/index.tsWhy this split exists
The next PR needs one narrow question answered first:
This PR answers that without taking on product behavior:
That keeps the behavior PR focused on command policy and output, not on storage traversal.
Boundary this PR is trying to establish
session-store.tsStoredStoreAuthSummary[]conflayout knowledgeNot changed / deferred
shopify auth listcommand in this PR. This PR is only the storage projection; command behavior lands upstack.LocalStorage.entries()/ enumeration API in cli-kit. Follow-through review correctly noted thatsession-store.tsstill relies on the underlyingconflayout to discover existing buckets; fixing that should be a focused storage follow-up before adding more local-auth inventory features.