Add subscription migration list command - #8478
Merged
Merged
Conversation
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -86,6 +86,7 @@ export declare function appendFile(path: string, content: string): Promise<void>
export declare function appendFileSync(path: string, data: string): void;
export interface WriteOptions {
encoding: BufferEncoding;
+ flag?: 'w' | 'wx';
}
/**
* Writes content to file at path.
|
dmerand
reviewed
Sep 4, 2026
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
dmerand
reviewed
Sep 4, 2026
dmerand
approved these changes
Sep 4, 2026
dmerand
left a comment
Contributor
There was a problem hiding this comment.
This LGTM from a code standpoint. My comments about output format are non-blocking, though my opinion is that we don't need so much code to handle output formatting when that's already handled well-enough by the OS.
Replace the buffered listMigratableSubscriptions with an async generator,
iterateMigratableSubscriptionPages, that yields each Partners API page as
it arrives while keeping the first=250, opaque cursor, null/blank/repeated
cursor and null-app guards.
Without --json the command now writes the CSV header with page one and
each later non-empty page to stdout before the next page is requested, so
a 100k-row export is never held in memory and a later page failure leaves
the rows already written as valid partial CSV. With --json every page is
still collected first and exactly one {schemaVersion: 1, subscriptions}
document is written only after all pages succeed.
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
Assisted-By: devx/0b604c20-c9ef-42f2-a0b6-f4cb3118b82f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds the subscription migration command:
The command:
migratableAppSubscriptionsPartners CLI GraphQL query;UNSCHEDULED,SCHEDULED, orMIGRATED;--json;The read model can preserve historical
NONEnotification values returned by the API without re-enablingNONEas a schedule-input option.Examples
Verification