Conversation
XFU and GBX defined subunit as an empty string in currency_non_iso.yml, while currencies without a subunit in currency_iso.yml (e.g. JPY) leave subunit null. Align the non-ISO entries with that convention. Fixes Shopify#353
Author
|
I've signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currencies without a subunit are represented two different ways depending on which file they come
from.
currency_iso.ymlleavessubunitunset for them, so it loads asnil;currency_non_iso.ymlwrites
subunit: '', which loads as an empty string. Callers that check the subunit therefore have tohandle both, and a truthiness check quietly gets it wrong for one of the two sources.
This drops the empty-string values for
xfuandgbx, the two non-ISO entries with no subunit, sothey load as
nillike their ISO counterparts. The loader spec gains a case pinning that, alongsidethe existing assertion on the same file.
Fixes #353