Skip CLI tests in Memleak - #995
Merged
Merged
Conversation
Assisted-By: devx/348380ff-5362-4e75-b229-8f6db00a32f6
alexcrocha
approved these changes
Aug 7, 2026
alexcrocha
left a comment
alexcrocha
left a comment
Contributor
There was a problem hiding this comment.
Do we know what exactly in the cli tests is making memleak jobs so slow?
Member
Author
|
I know which individual CLI tests dominate yet. RubyMemcheck runs the test process under Valgrind, so tests that perform more work generally add more time. And in cli tests, we run several full index cycles, which can be the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI suite adds substantial time to the Memleak job as it grows. This change excludes
test/cli_test.rbfromruby_test:valgrindand keeps it in the regularruby_testtask.