Skip to content

Skip non-theme directories when preloading files (for the LSP) #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip non-theme directories when preloading files (for the LSP) #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/theme-language-server-common/src/documents/DocumentManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,18 @@ export class DocumentManager {

// We'll only load the files that aren't already in the store. No need to
// parse a file we already parsed.
//
// NOTE: We restrict to Shopify theme directories to avoid loading large
// data files (e.g. data/*.json) that are not part of the theme itself.
// A 175MB JSON file parsed into an AST can easily consume 1–2 GB of heap.
const THEME_DIRS = /\/(assets|blocks|config|layout|locales|sections|snippets|templates)\//;
const filesToLoad = await recursiveReadDirectory(
this.fs,
rootUri,
([uri]) => /\.(liquid|json)$/.test(uri) && !this.sourceCodes.has(uri),
([uri]) =>
/\.(liquid|json)$/.test(uri) &&
THEME_DIRS.test(uri) &&
!this.sourceCodes.has(uri),
);

progress.report(10, 'Preloading files');
Expand Down
Loading