Skip to content

Limit admin print action shouldRender targets to details #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melissaluu merged 1 commit into from
Aug 27, 2026
Merged

Limit admin print action shouldRender targets to details #4655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/print-action-should-render-detail-targets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/ui-extensions': patch
'@shopify/ui-extensions-tester': patch
---

Remove unsupported bulk print action `shouldRender` targets from Admin UI extension types and generated docs.
4 changes: 0 additions & 4 deletions packages/ui-extensions-tester/src/admin/factories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,6 @@ const adminMockFactories: AdminMockFactory = {
// Should-render targets (print action)
'admin.order-details.print-action.should-render': createShouldRenderMock,
'admin.product-details.print-action.should-render': createShouldRenderMock,
'admin.order-index.selection-print-action.should-render':
createShouldRenderMock,
'admin.product-index.selection-print-action.should-render':
createShouldRenderMock,
};

// ---------------------------------------------------------------------------
Expand Down
118 changes: 52 additions & 66 deletions ...ons/docs/surfaces/admin/generated/admin_extensions/2026-10-rc/generated_docs_data_v2.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 0 additions & 14 deletions ...ages/ui-extensions/docs/surfaces/admin/generated/admin_extensions/2026-10-rc/targets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3295,18 +3295,6 @@
"ShouldRenderApi"
]
},
"admin.order-index.selection-print-action.should-render": {
"components": [],
"apis": [
"ShouldRenderApi"
]
},
"admin.product-index.selection-print-action.should-render": {
"components": [],
"apis": [
"ShouldRenderApi"
]
},
"admin.app.tools.data": {
"components": [],
"apis": [
Expand Down Expand Up @@ -3436,13 +3424,11 @@
"admin.order-fulfilled-card.action.should-render",
"admin.order-index.action.should-render",
"admin.order-index.selection-action.should-render",
"admin.order-index.selection-print-action.should-render",
"admin.product-details.action.should-render",
"admin.product-details.configuration.should-render",
"admin.product-details.print-action.should-render",
"admin.product-index.action.should-render",
"admin.product-index.selection-action.should-render",
"admin.product-index.selection-print-action.should-render",
"admin.product-variant-details.action.should-render",
"admin.product-variant-details.configuration.should-render"
]
Expand Down
174 changes: 106 additions & 68 deletions packages/ui-extensions/docs/surfaces/admin/generated/app_home/generated_docs_data_v2.json
View file
Open in desktop

Large diffs are not rendered by default.

174 changes: 106 additions & 68 deletions ...on/2026-07-rc/generated_docs_data_v2.json → ...on/2026-10-rc/generated_docs_data_v2.json
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 1 addition & 17 deletions packages/ui-extensions/src/surfaces/admin/extension-targets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ export interface ExtensionTargets {
ShouldRenderOutput
>;

// Admin print action and bulk print action shouldRender targets
// Admin print action shouldRender targets

/**
* A non-rendering target that controls whether the order details print action appears in the **Print** menu. Use this to conditionally show or hide your print action based on order properties, user permissions, or external data.
Expand All @@ -679,22 +679,6 @@ export interface ExtensionTargets {
ShouldRenderOutput
>;

/**
* A non-rendering target that controls whether the order index selection print action appears in the **Print** menu. Use this to conditionally show or hide your bulk print action based on selection criteria, user permissions, or external data.
*/
'admin.order-index.selection-print-action.should-render': RunnableExtension<
ShouldRenderApi<'admin.order-index.selection-print-action.should-render'>,
ShouldRenderOutput
>;

/**
* A non-rendering target that controls whether the product index selection print action appears in the **Print** menu. Use this to conditionally show or hide your bulk print action based on selection criteria, user permissions, or external data.
*/
'admin.product-index.selection-print-action.should-render': RunnableExtension<
ShouldRenderApi<'admin.product-index.selection-print-action.should-render'>,
ShouldRenderOutput
>;

/**
* A runnable target that enables your app to expose data to [Sidekick](/docs/apps/build/sidekick/build-app-data). Use this target to register tools that Sidekick can invoke to search your app's data and answer merchant questions.
*/
Expand Down
Loading