Limit admin print action shouldRender targets to details - #4656
Merged
Conversation
Assisted-By: devx/d6c80abe-fad1-4843-8115-86a365f713b8
Contributor
|
This PR targets a stable release branch ( When you open the forward-port PR, include a line like this in its body so the Accepted formats (comma-separated for multiple):
If a forward-port isn't needed (e.g., the change is stable-only), you can remove the |
vividviolet
approved these changes
Aug 27, 2026
Contributor
|
✓ Forward-ported in #4655. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes unsupported Admin selection print-action
shouldRendertargets from the2026-07docs/types branch.Keeps the supported detail targets:
admin.order-details.print-action.should-renderadmin.product-details.print-action.should-renderRemoves unsupported selection targets:
admin.order-index.selection-print-action.should-renderadmin.product-index.selection-print-action.should-renderWhy
Core and Admin Web now support print-action
should_renderonly for detail pages. The selection/bulk print-action targets should not be advertised or typed for the 2026-07 Admin UI Extensions branch.Follow-up to the
2025-10cleanup: #4652World support PRs: shop/world#2016728 and shop/world#2016776
Note: the
2026-07branch currently stores generated Admin docs under the existing2026-07-rcgenerated folder, so this PR updates that tracked folder.Testing
yarn workspace @shopify/ui-extensions docs:admin 2026-07-rc 2026-07-rcgit diff --checkyarn lintyarn type-check