fix(admin): use control-generic wording for selectable prop docs [2026-01] - #4669
Merged
Conversation
Backport of #4667 to 2026-01. `BaseSelectableProps` (`disabled`, `value`), `BaseCheckableProps` (`label`, `name`) and the shared `PreactCheckboxProps` / `PreactCheckboxElement` `value` accessor described themselves as a checkbox. All are shared by non-checkbox components, so the copy is inherited by Choice and Option (via `BaseOptionProps`) and by Switch (which extends `PreactCheckboxProps` / `PreactCheckboxElement`). Replace "checkbox" with "control". State verbs follow each interface's own family vocabulary: `BaseSelectableProps` uses "selected", matching its name and the Option/Choice wording; the checkable declarations keep "checked". Refs shop/issues-learn#2959 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
We detected some changes in |
davejcameron
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4667 to
2026-01.What
Four shared declarations describe themselves as a checkbox, and all of them are inherited by components that aren't checkboxes:
BaseSelectableProps(disabled,value) →BaseOptionProps→ Choice, OptionBaseCheckableProps(label,name) → SwitchPreactCheckboxProps/PreactCheckboxElement(value) → Switch (SwitchProps extends PreactCheckboxProps,class Switch extends PreactCheckboxElement)Wording
"checkbox" → "control". State verbs follow each interface's own family vocabulary:
BaseSelectablePropsuses selected (matching its name and the Option/Choice wording), the checkable declarations keep checked. "control" matchesui-api-design, the upstream source of truth.Change
Same 8 sentence-level replacements as #4667, applied to this branch's
components.d.tsand generated docs. Each is asserted to appear an exact expected number of times before writing, so version drift fails loudly rather than silently no-op'ing. Generated JSON was patched textually rather than regenerated; all files re-parse as valid JSON and the diff is symmetric (3 files changed, 25 insertions(+), 25 deletions(-)).Refs shop/issues-learn#2959
🤖 Generated with Claude Code