fix(search): keep the global search icon from overlapping text in compact density - #70
Open
ndandan wants to merge 1 commit into
Open
fix(search): keep the global search icon from overlapping text in compact density#70ndandan wants to merge 1 commit into
ndandan wants to merge 1 commit into
Conversation
The global search input reserves left padding (2.75rem) for its absolutely-positioned magnifying-glass icon. In compact density the generic `.form-control` shrink rule (higher specificity) collapsed that padding to .55rem, sliding the placeholder under the icon. Exempt the search input from the compact shrink so its own padding always wins. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ndandan
added a commit
to ndandan/Prismarr
that referenced
this pull request
Jul 11, 2026
…worker mode - Fork-only: document opt-in PRISMARR_WORKER worker mode with homelab benchmark figures (health poll ~15x, Films render ~10x; Discover unchanged) - Add open upstream PR Shoshuo#70 (search-icon compact-density fix) to pending list - Tech stack: note worker mode is optional/off by default, not always on Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In compact density, the global top-bar search input's placeholder text slides underneath its magnifying-glass icon.
Why
The search input reserves
padding-left: 2.75remfor its absolutely-positioned icon (.prismarr-search-input). But the compact-density rulehas higher specificity (
body.density-compact .form-control=0,2,1vs.prismarr-search-input=0,1,0), so in compact mode it overrides the reserved padding down to.55remand the placeholder renders on top of the icon. (Comfortable density is unaffected — there the input's own rule wins by source order.)Fix
Exempt the search input from the compact shrink so its fixed icon padding always applies:
One-line CSS change in
base.html.twig— no JS/PHP/Twig logic touched.Verified
Confirmed in-browser in compact density: computed
padding-leftgoes8.8px→44px(2.75rem), leaving an ~11.6px gap between the icon and the text. No regression in comfortable density.🤖 Generated with Claude Code