fix(qbittorrent): guard against stale pagination responses - #82
Open
jeromelefeuvre wants to merge 1 commit into
Open
fix(qbittorrent): guard against stale pagination responses#82jeromelefeuvre wants to merge 1 commit into
jeromelefeuvre wants to merge 1 commit into
Conversation
jeromelefeuvre
force-pushed
the
fix/qbittorrent-pagination-race
branch
from
July 24, 2026 04:24
7916076 to
4d84db8
Compare
4 tasks
refreshData() aborts the previous in-flight fetch before firing a new one, but abort() is a no-op once a response has already arrived — common on localhost, where the round-trip can beat the click-to-JS-execution delay. A periodic poll response for the old page could then land after a user's page-change click and silently snap the view back to the previous page. Add a sequence counter so a response is only applied if no newer request has been issued since, regardless of whether abort() worked. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jeromelefeuvre
force-pushed
the
fix/qbittorrent-pagination-race
branch
from
July 28, 2026 03:59
4d84db8 to
4d16c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshData()aborts the previous in-flight fetch before firing a new one, butabort()is a no-op once a response has already arrived — common on localhost, where the round-trip can beat the click-to-JS-execution delay.abort()actually worked.Test plan
make lint-twigpasses on the changed template🤖 Generated with Claude Code