feat: classify failed-charge alerts by reason with dedup and webhook - #996
Merged
orunganiekan merged 7 commits intoAug 31, 2026
Conversation
|
@islarmeeyah-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a failed-charge alert classification system that uses
ChargeResultand DLQ payloads to distinguish failure reasons, rate-limits repeated alerts per subscriber, and sends webhook notifications through the configurableWEBHOOK_URL. It replaces flat failure alerts with reason-aware, deduplicated, actionable webhook events.Related Issue
Changes
🚨 Failed-Charge Alert Classifier
[ADD]
alert-failed-charges.tsChargeResultfields to normalized failure reasons (allowance, grace, card, etc.).WEBHOOK_URL; no PagerDuty-specific APIs are used.[ADD]
config.tsWEBHOOK_URL, dedup window duration, and failure-reason handling options.[ADD]
tests/alert-failed-charges.test.ts[ADD]
tests/fixtures/batch-results.jsonChargeResultand DLQ failure fixtures for classification and dedup scenarios.[MODIFY]
package.json,tsconfig.jsonVerification Results
config.tsand asserted in testsbatch-results.jsonfixtures drive classification, dedup, and webhook testsCloses #883