Support unconfirmed transactions lookup #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for looking up unconfirmed transactions from the transaction pool. When a transaction is queried by ID and not found in the database, the API now checks the unconfirmed transaction pool before returning a 404 error.
Key changes:
- Added
Unconfirmedboolean field toTransactionandV2Transactiontypes to distinguish between confirmed and unconfirmed transactions - Implemented
UnconfirmedTransactionandUnconfirmedV2Transactionmethods in the Explorer to search the transaction pool - Updated transaction API handlers to fall back to checking the unconfirmed pool when transactions are not found in the database
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| explorer/types.go | Added Unconfirmed field to Transaction and V2Transaction structs with omitempty JSON tag |
| explorer/explorer.go | Implemented UnconfirmedTransaction and UnconfirmedV2Transaction methods to search the transaction pool |
| explorer/events.go | Modified CoreToExplorerV1Transaction and CoreToExplorerV2Transaction to set Unconfirmed flag |
| api/server.go | Updated transaction handlers to check unconfirmed pool as fallback; added interface methods |
| api/api_test.go | Added tests for confirmed and unconfirmed V1 transaction lookup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chris124567
force-pushed
the
christopher/support-unconfirmed-transactions-lookup
branch
from
b9306be to
caab760
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
peterjan
approved these changes
Jan 12, 2026
ChrisSchinnerl
approved these changes
Jan 12, 2026
ChrisSchinnerl
deleted the
christopher/support-unconfirmed-transactions-lookup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the backend part of #291
I was mistaken in the dev sync about this already being partially complete, I was looking at unpushed code...