State the version literally so F-Droid can read it - #31
Merged
Merged
Conversation
F-Droid's checkupdates job failed on the submission: checkupdate failed for com.hazel.android : Couldn't find any version information ..got package=com.hazel.android, version=None, vercode=None It reads versionName and versionCode straight out of build.gradle.kts with a regular expression and never runs Gradle, so the previous release holding them in gradle.properties left nothing for it to find. The same would be true of any computed expression. Both are literals in defaultConfig again. The per-architecture codes are derived from the literal rather than the other way round, so there is still one copy of the number, and release.ps1 rewrites that copy. Cuts 1.0.6 at codes 300 to 304.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The fdroiddata submission pipeline ran 9 jobs.
fdroid lint,fdroid rewritemeta,schema validation,check source codeandtools check scriptsall passed. One failed:The cause
fdroidserver reads the version out of
build.gradle.ktswith a regular expression and never runs Gradle:Both need a literal. 1.0.5 had
versionCode = hazelVersionCode * abiCodeSpanandversionName = hazelVersionName, reading fromgradle.properties, so both matched nothing.That was introduced in the previous release to make
AutoUpdateMode: Versionwork without hand-editing the recipe. It fixed that and broke this. A build argument would fail the same way: what is not in the file cannot be read from it.The change
Both are literals in
defaultConfigagain:The per-architecture codes now derive from the literal rather than the other way round, via
android.defaultConfig.versionCode, so there is still exactly one copy of the number.tools/release.ps1rewrites that copy instead ofgradle.properties.AutoUpdateModeis unaffected: the recipe still carries no version-specific literal, sinceoutput:uses$$VERSION$$and there is nogradleprops.Verified
fdroidserver's own regexes, imported from the installed package rather than retyped:
Merged manifests with no
-Parguments, which is how F-Droid builds:Also
Store changelogs regenerated as 300-304, and short enough that the listing will not truncate them this time. The recipe targets v1.0.6; neither v1.0.4 nor v1.0.5 can be submitted, the first for the foojay resolver and the second for this.