Add flake8-unused-arguments to linting and pre-commit#2
Draft
Sidartha-CT wants to merge 376 commits intomasterfrom
Draft
Add flake8-unused-arguments to linting and pre-commit#2Sidartha-CT wants to merge 376 commits intomasterfrom
Sidartha-CT wants to merge 376 commits intomasterfrom
Conversation
lf_rssi_check.py is not fully funcitonal and dependent on modify_vap.py which is broken. Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Note: some of the configuations do not work, created Jira, LAN-4204 test_ip_connection, logging not setup, also setting the mode does not work, help not properly formatted Verified: ./test_ip_connection.py\ --mgr 192.168.50.100\ --upstream_port eth2\ --radio wiphy0\ --num_stations 3\ --proxy\ --security wpa2\ --ssid ax1800_5g\ --passwd lf_ax1800_5g\ --mode 1\ --timeout 120\ --debug Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./test_generic.py --mgr 192.168.50.100\ --upstream_port 1.1.eth2\ --radio wiphy0\ --num_stations 3\ --security wpa2\ --ssid ax1800_5g\ --passwd lf_ax1800_5g\ --type lfping\ --dest 192.168.50.102\ --test_duration 1m\ --interval 5s\ --debug Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./chamber_ctl.py --help Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./sta_connect_example.py --help Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
This script is a development script Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…ps.py This script is a work in progress, does not function. The help references ./test_ipv4_veriable_time.py moving to scripts deprecated Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…_time Verified: ./lf_create_vap_cv.py\ --mgr 192.168.50.100\ --port 8080\ --lf_user lanforge\ --lf_password lanforge\ --vap_radio 1.1.wiphy2\ --vap_freq 5180\ --vap_ssid test_vap\ --vap_passwd password\ --vap_security wpa2\ --vap_upstream_port 1.1.eth2\ --log_level debug Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…ipv4_ttls.py The script is non-funcational moving to scripts deprecated. Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…ript Verification: /sta_connect2.py --help Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
py-scripts.test_ip_variable_time Verified: ./lf_create_vap_cv.py\ --mgr 192.168.50.100\ --port 8080\ --lf_user lanforge\ --lf_password lanforge\ --vap_radio 1.1.wiphy2\ --vap_freq 5180\ --vap_ssid test_vap\ --vap_passwd password\ --vap_security wpa2\ --vap_upstream_port 1.1.eth2\ --log_level debug Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
This script worked first time Verification: ./sta_scan_test.py\ --mgr 192.168.50.11\ --ssid ax1800_5g\ --passwd lf_ax1800_5g\ --security wpa2\ --radio wiphy0 Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./test_status_msg.py ./test_status_msg.py\ --mgr 192.168.50.11\ --action run_test Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…nds fixes from d69f0e6 to the list_cxs method. Verification: ./test_fileio.py --macvlan_parent eth1 --num_ports 2 --use_macvlans --first_mvlan_ip 192.168.48.15 --netmask 255.255.255.0 --gateway 192.168.45.24 --test_duration 1m --use_test_groups --write_only_test_group cgio-0000 --read_only_test_group cgio-0000 ./test_fileio.py --macvlan_parent eth1 --num_ports 2 --use_macvlans --first_mvlan_ip 192.168.48.15 --netmask 255.255.255.0 --gateway 192.168.45.24 --test_duration 1m --use_test_groups --write_only_test_group cgio-0000 --read_only_test_group cgio-0001 Signed-off-by: Liam Reynolds <liam.reynolds@candelatech.com>
This file is a library or module so used by other TIP files Verification: ./tip_station_powersave.py --help Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…cated/test_l3_scenario_throughput.py This script was initially created in 2020, there are hard coded values and the script has not been maintained. Moving to scripts deprecated Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./test_fileio.py\ --mgr 192.168.50.100\ --radio 1.wiphy0\ --test_duration 1m\ --macvlan_parent eth2\ --num_ports 3\ --use_macvlans\ --use_ports eth2#0,eth2#1,eth2#2\ --connections_per_port 2\ --mode both Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
The history on this script indicates is was specific for a customer. Possibly need to move to customer specific repo Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>y-scripts/lf_ping_sweep.py flake8 compliance The history on this script indicates is was specific for a customer. The script needs to be run on lanforge Verification: ./lf_ping_sweep.py ./lf_ping_sweep.py\ --ethernet_interface eth2\ --target_ip 192.168.50.1/24\ --data_lengths 1024\ --duration 1m\ --csv_name ping_sweep_2\ --reporting_down_time_percent 40% ./lf_ping_sweep.py\ -e eth2\ -ip 192.168.50.1/24\ --duration 20s\ --csv_name ping_sweep_1\ --reporting_down_time_percentage 30% Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./lf_interop_modify.py --help Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
added a comment on the usefulness of the example Verification: ./bssid_to_dut.py\ --mgr 192.168.50.100\ --ssid ax1800_5g\ --passwd lf_ax1800_5g\ --security wpa2\ --radio wiphy2\ --dut_name AX1800 Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verification: ./bssid_to_dut.py\ --mgr 192.168.50.100\ --ssid ax1800_5g\ --passwd lf_ax1800_5g\ --security wpa2\ --radio wiphy2\ --dut_name AX1800 Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…to align with the report - Removed redundant DataFrame columns at the monitor level. - Updated generate_report logic to calculate averages using all columns present in the CSV. Verfied CLI: python3 lf_interop_throughput.py --mgr 192.168.204.74 --mgr_port 8080 --upstream_port eth1 --test_duration 1m --download 1000000 --traffic_type lf_udp --device_list 1.11,1.12,1.360,1.400 Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
Verified: ./lf_rx_sensitivity_test.py\ --mgr 192.168.50.100\ --port 8080\ --lf_user lanforge\ --lf_password lanforge\ --instance_name rx-sensitivity-instance\ --config_name test_con\ --upstream 1.1.eth2\ --dut asus_ax1800\ --duration 15s\ --station 1.1.sta0000\ --download_speed 85%\ --upload_speed 10%\ --raw_line 'txo_preamble: VHT (/AC)'\ --raw_line 'txo_mcs: 7 OFDM, HT+'\ --raw_line 'spatial_streams: 2'\ --raw_line 'bandw_options: 80'\ --raw_line 'txo_sgi: OFF'\ --raw_line 'txo_retries: No Retry'\ --raw_line 'txo_txpower: 17'\ --raw_line 'traffic_types: UDP'\ --test_rig Testbed-01\ --pull_report Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
…load. Check_if_complete now only runs when a scenario has been loaded to prevent timing out. The --timeout argument now correctly reads input as an int. Verification: ./scenario.py --start TG ./scenario.py --load FACTORY_DLFT --timeout 30 Signed-off-by: Liam Reynolds <liam.reynolds@candelatech.com>
Using the --save_config argument alongside --use_test_groups will cause the script to finish after the build step, before starting. This will result in a read-only and/or a write-only CX group which can be run using scenario.py at a later time. Verification: ./test_fileio.py --use_macvlans --macvlan_parent eth1 --num_ports 2 --first_mvlan_ip 192.168.0.34 --netmask 255.255.255.0 --gateway 192.168.0.105 --use_test_groups --write_only_test_group WOTG --read_only_test_group ROTG --save_config Signed-off-by: Liam Reynolds <liam.reynolds@candelatech.com>
Chuck was encountering a hundreds of backup files because QA automation does do_upgrade every day. Signed-off-by: Jed Reynolds <jreynolds@candelatech.com>
Verified: ./lf_test_gen.py (then connected to 192.168.100.116) Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
…e title on the email. Verified: Automation Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
There are no kernel files on AT7, so check the array size before running du -hc. Corrects spelling.
Some vnc logs can fill with errors very rapidly. Adds .vnc/*:1.log files.
On Debian systems (eg AT7), the Apache log directory is /var/log/apache2, not /var/log/httpd.
* class AddAdbFlags * additional parameters for post_add_adb() * adds support for climate control enabled chambers in post_add_chamber() * class AddMldLinkFlags * post_add_mld_link() adds support for MLD * adds OWE support for AddProfileProfileFlags * adds mld_sub_vap support to AddVapFlags * adds pmkid support for post_set_wifi_corruptions * adds post_show_mld_link()
Note: this script uses scrapli which is not part of LANforge Scripts
dependencies.
Help Summary:
This script will perform an update on lanforge of:
GUI version,
Kernel version,
then reboot,
run check_large_files.bash
Verified:
./lf_update.py \
--mgr 192.168.50.103 \
--root_user root \
--root_password lanforge \
--user lanforge \
--user_password lanforge \
--mgr_ssh_port 22\
--lfver 5.5.1\
--kver 6.15.6+\
--log_level info
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Note: this script uses scrapli which is not part of LANforge Scripts
dependencies.
Help Summary:
This script will perform an update on lanforge of:
GUI version,
Kernel version,
then reboot,
run check_large_files.bash
Verified:
./lf_update.py \
--mgr 192.168.50.103 \
--root_user root \
--root_password lanforge \
--user lanforge \
--user_password lanforge \
--mgr_ssh_port 22\
--lfver 5.5.1\
--kver 6.15.6+\
--log_level info
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verified:
./lf_update.py \
--mgr 192.168.50.103 \
--root_user root \
--root_password lanforge \
--user lanforge \
--user_password lanforge \
--mgr_ssh_port 22\
--lfver 5.5.1\
--kver 6.15.6+\
--log_level info
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Alex Gavin <alex.gavin@candelatech.com>
Verified:
with lf_tx_power.py
"args":[
"--scheme","ssh",
"--dest", "192.168.215.198",
"--port", "22",
"--user", "root",
"--passwd", "hfcl!@ion",
"--prompt", "root@HFCL:~#",
"--series", "NA",
"--band", "5g",
"--module", "cc_module_uci",
"--module_scrapli",
"--timeout", "3",
"--ap", "HFCL",
"--ap_band_slot_5g", "NA",
"--wlan", "NA",
"--wlan_id", "NA",
"--wlan_ssid", "ion_5g",
"--tag_policy", "NA",
"--policy_profile", "NA",
"--pathloss", "59",
"--antenna_gain", "6",
"--lfmgr", "192.168.212.55",
"--upstream_port", "eth1",
"--lfresource", "1",
"--radio", "wiphy0",
"--station", "sta0000",
"--ssid", "ion_5g",
"--ssidpw", "12345678",
"--security", "wpa2",
"--bssid", "DEFAULT",
"--no_cleanup_station",
"--channel", "40",
"--bandwidth", "160",
"--vht160",
"--nss", "2",
"--txpower", "4.25",
"--duration", "25",
"--outfile", "test001",
"--no_cleanup",
"--test_rig", "HFCl",
"--series", "HFCL",
"--html_report",
"--pf_dbm", "8"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
parameters
Verified:
"args":[
"--scheme","ssh",
"--dest", "192.168.215.198",
"--port", "22",
"--user", "root",
"--passwd", "hfcl!@ion",
"--prompt", "root@HFCL:~#",
"--series", "NA",
"--band", "5g",
"--module", "cc_module_uci",
"--module_scrapli",
"--timeout", "3",
"--ap", "HFCL",
"--ap_band_slot_5g", "NA",
"--wlan", "NA",
"--wlan_id", "NA",
"--wlan_ssid", "ion_5g",
"--tag_policy", "NA",
"--policy_profile", "NA",
"--pathloss", "59",
"--antenna_gain", "6",
"--lfmgr", "192.168.212.55",
"--upstream_port", "eth1",
"--lfresource", "1",
"--radio", "wiphy0",
"--station", "sta0000",
"--ssid", "ion_5g",
"--ssidpw", "12345678",
"--security", "wpa2",
"--bssid", "DEFAULT",
"--no_cleanup_station",
"--channel", "40",
"--bandwidth", "160",
"--vht160",
"--nss", "2",
"--txpower", "4.25",
"--duration", "25",
"--outfile", "test001",
"--no_cleanup",
"--test_rig", "HFCl",
"--series", "HFCL",
"--html_report",
"--pf_dbm", "8"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Updated flake8 issue, modified quotes Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
updated to use pramiko to do the LANforge reset as proved to be reliable
Verified:
// ./lf_update.py
"args":[
"--mgr", "192.168.50.104",
"--root_user", "root",
"--root_password", "lanforge",
"--user", "lanforge",
"--user_password", "lanforge",
"--mgr_ssh_port", "22",
"--log_level","info",
"--lfver","5.5.1",
"--kver","6.15.6+"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Verified:
vscode
"args":[
"--scheme","ssh",
"--dest", "192.168.215.167",
"--port", "22",
"--user", "root",
"--passwd", "hfcl!@ion",
"--prompt", "root@HFCL:~#",
"--series", "NA",
"--band", "5g",
"--module", "cc_module_uci",
"--module_scrapli",
"--timeout", "3",
"--ap", "HFCL",
"--ap_band_slot_5g", "NA",
"--wlan", "NA",
"--wlan_id", "NA",
"--wlan_ssid", "ion_5g",
//"--wlan_ssid", "hfcl_5g",
"--tag_policy", "NA",
"--policy_profile", "NA",
"--pathloss", "59",
"--antenna_gain", "6",
"--lfmgr", "192.168.212.55",
"--upstream_port", "eth1",
"--lfresource", "1",
"--radio", "wiphy0",
"--station", "sta0000",
"--ssid", "ion_5g",
//"--ssid", "hfcl_5g",
"--ssidpw", "12345678",
"--security", "wpa2",
"--bssid", "DEFAULT",
"--no_cleanup_station",
"--channel", "100",
"--bandwidth", "160",
"--vht160",
"--nss", "2",
"--txpower", "4.25",
"--duration", "25",
"--outfile", "test001",
"--no_cleanup",
"--test_rig", "HFCl",
"--series", "HFCL",
"--html_report",
"--pf_dbm", "8"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
updated to pass in the timeouts and suggested timeouts based on the
lANforge type
Verified:
// ./lf_update.py 523c
"args":[
"--mgr", "192.168.50.104",
"--root_user", "root",
"--root_password", "lanforge",
"--user", "lanforge",
"--user_password", "lanforge",
"--mgr_ssh_port", "22",
"--log_level","info",
"--lfver","5.5.1",
"--kver","6.15.6+",
"--user_timeout","10",
"--root_timeout","300",
"--log_level","info"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
- Implemented get_layer4_data() to fetch uc-avg, uc-min, uc-max, total URLs, rx rate, bytes read, and error counts for all CXs VERIFIED CLI: python3 lf_ftp.py --file_sizes 10MB --mgr 192.168.242.2 --traffic_duration 1m --directions Download --clients_type Real --ap_name Netgear --bands 2.4G --upstream_port eth1 Signed-off-by: Nikhita <kadali.nikhita@candelatech.com>
- Implemented get_layer4_data() to fetch uc-avg, uc-min, uc-max, total URLs, rx rate, bytes read, and error counts for all CXs VERIFIED CLI: python3 lf_webpage.py --ap_name Cisco --mgr 192.168.242.2 --upstream_port eth2 --duration 1m --bands 5G --client_type Real --file_size 2MB Signed-off-by: Nikhita <kadali.nikhita@candelatech.com>
…n report - Modified incremental_capacity list based on MAC ID configured devices - Included RTT metrics in the generated report VERIFIED CLI : python3 lf_interop_throughput.py --mgr 192.168.242.2 --mgr_port 8080 --upstream_port eth2 --test_duration 1m --download 1000000 --traffic_type lf_udp --ssid OpenWifi_psk2 --passwd OpenWifi --security wpa2 --config --device_list 1.113,1.115,1.21,1.17,1.14 --incremental_capacity 1,3,5 Signed-off-by: Renusree-ct <renusree.rayavarapu@candelatech.com>
…ning
of the update
Verification:
// ./lf_update.py 523c
"args":[
"--mgr", "192.168.50.104",
// "--mgr", "192.168.101.137",
"--root_user", "root",
"--root_password", "lanforge",
"--user", "lanforge",
"--user_password", "lanforge",
"--mgr_ssh_port", "22",
"--log_level","info",
"--lfver","5.5.1",
"--kver","6.15.6+",
"--user_timeout","10",
"--root_timeout","300",
"--log_level","info"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Updated the search to include the AT7 with different prompt Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
updated the parcing of the comms_prompt_pattern
Verified:
"args":[
"--mgr", "192.168.101.137",
"--root_user", "root",
"--root_password", "lanforge",
"--user", "lanforge",
"--user_password", "lanforge",
"--mgr_ssh_port", "22",
"--log_level","info",
"--lfver","5.5.1",
"--kver","6.15.6+",
"--user_timeout","10",
"--root_timeout","300",
"--log_level","info"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
Sidartha-CT
pushed a commit
that referenced
this pull request
Oct 9, 2025
…ws up lf qa
Updated so that the meta data is generated. This will not pass bugbear
that will need to be revisited
Verified:
// lf_check for email 192.168.100.132 CT-US-005 (resource #2 192.168.101.91)
"args": [
"--json_rig","./ct_rig_json/ct_us_005_rig_AXE11000.json",
"--json_dut","./ct_dut_json/ct_005_AXE11000_dut.json",
"--json_test","./ct_tests_json/ct_us_005/ct_ap_auto/ct_ap_auto_basic_cx_005.json:ct_ap_auto_basic_cx_005",
"--path","/home/lanforge/html-results/ct_us_005",
"--log_level","debug"
]
Signed-off-by: Chuck SmileyRekiere <chuck.smileyrekiere@candelatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.