feat: support multiple Node.js versions#13
Merged
Conversation
…criptions in CONTRIBUTING.md
There was a problem hiding this comment.
Pull request overview
Adds multi-version Node.js compatibility support across the CLI/library by updating runtime requirements, CI coverage, and introducing an automated CLI smoke suite to validate behavior across Node versions.
Changes:
- Expand GitHub Actions test workflow to run on a Node.js version matrix and split compat vs coverage runs.
- Introduce a CLI smoke test script and wire it into
npm test/test:compat. - Update CLI prompt flows to support non-interactive operation via
IPromptOptionsand adjust dependency/engine constraints accordingly.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
source/shared/cli/utilities.ts |
Adds non-interactive support to inquire.continue via promptOptions. |
source/key-encryptions/RSA.ts |
Threads IPromptOptions into demo flow steps to support non-interactive runs. |
source/key-encryptions/ElGamal.ts |
Same as above for ElGamal demo flow. |
source/key-encryptions/DiffieHellman.ts |
Same as above for Diffie-Hellman demo flow. |
scripts/test-cli.js |
Adds automated smoke coverage for algorithms and demonstrations via runCLI. |
package.json |
Adjusts dependencies/engines and adds test:cli / test:compat scripts. |
README.md |
Updates documented Node/NPM requirements and tested Node versions. |
CONTRIBUTING.md |
Updates development requirements and script documentation. |
.nvmrc |
Sets default dev Node version to 14.18.0. |
.npmrc |
Disables engine-strict for installs. |
.github/workflows/test.yml |
Runs CI tests across multiple Node versions and gates coverage to one version. |
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:35
actions/checkout@v6is not a valid released major version of the checkout action (current stable majors are lower). This will cause the workflow to fail to resolve the action. Use an existing major (e.g.,actions/checkout@v4).
- name: Action | Checkout Repository Code
uses: actions/checkout@v6
Co-authored-by: Copilot <copilot@github.com>
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support multiple Node.js versions by adding tests, updating pipelines, and using different dependencies' versions.
Important Details
Checklist