-
Notifications
You must be signed in to change notification settings - Fork 0
ci: update commitlint #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0f01947
f290c22
1884b2e
21b8534
5cd8336
dab335e
fff15be
3e36abc
96d826f
f29cf3f
06a3ed6
0f96829
7cdaf1c
9d6c3b2
e5aaeea
2a03d3c
a66ec31
35c77cd
6ed3376
7cee682
a18962f
2bc3afd
7fd3c83
0839cea
2c40036
3f83a3d
b175ac6
b93ff26
5e33d40
271fa11
7dde655
e2427d2
29f8415
a46461f
2bf27ae
420b37a
b8f1514
bce1cb5
f42b8da
0a453ca
8449315
cc3bf9f
96300dd
cfa4376
6b2a788
c5fb8ae
d0f139e
beea33d
a557f1a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| github: SiegeSailor |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,48 +5,80 @@ on: | |||||
| branches: | ||||||
| - main | ||||||
| - release | ||||||
| paths-ignore: | ||||||
| - "./.github/CODE_OF_CONDUCT.md" | ||||||
| - "./.github/CONTRIBUTING.md" | ||||||
| - "./.github/GOVERNANCE.md" | ||||||
| - "./.github/ISSUE_TEMPLATE/*" | ||||||
| - "./.github/pull_request_template.md" | ||||||
| - "./.github/SECURITY.md" | ||||||
| - "./.github/SUPPORT.md" | ||||||
| - "./images/*" | ||||||
| - "./README.md" | ||||||
| pull_request: | ||||||
| branches: | ||||||
| - main | ||||||
| - release | ||||||
| types: | ||||||
| - edited | ||||||
| - opened | ||||||
| - reopened | ||||||
| - synchronize | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
||||||
| jobs: | ||||||
| commitlint: | ||||||
| linting: | ||||||
| runs-on: ubuntu-latest | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
| pull-requests: read | ||||||
|
|
||||||
| steps: | ||||||
| - name: Action | Run Conventional Commitlint | ||||||
| uses: opensource-nepal/commitlint@v1 | ||||||
| - name: Action | Checkout Repository on Pull Request | ||||||
| uses: actions/checkout@v5.0.0 | ||||||
| if: github.event_name == 'pull_request' | ||||||
| with: | ||||||
| fetch-depth: 1 | ||||||
| ref: ${{ github.event.pull_request.head.sha }} | ||||||
| token: ${{ secrets.GITHUB_TOKEN }} | ||||||
|
|
||||||
| - name: Action | Set Up Python | ||||||
| uses: actions/setup-python@v6.0.0 | ||||||
| if: github.event_name == 'pull_request' | ||||||
| with: | ||||||
| python-version: 3.11.13 | ||||||
|
|
||||||
| - name: Setup | Install Commitlint | ||||||
| if: github.event_name == 'pull_request' | ||||||
| run: | | ||||||
| pip install commitlint | ||||||
|
||||||
| pip install commitlint | |
| python -m pip install commitlint==1.3.0 |
Copilot
AI
Apr 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says this update is just bumping commitlint in the workflow, but this PR also changes release configuration, dependency management (Poetry dependency groups), docs, and adds/updates multiple repository meta files (LICENSE/FUNDING/SECURITY/CHANGELOG). Please update the PR description/scope to reflect the full set of changes, or split into focused PRs.
Copilot
AI
Apr 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow now runs on pull_request events (see the on.pull_request trigger), but the release job has no job-level condition and will also run for PRs. On PRs, github.ref_name refers to a PR ref (e.g., 123/merge) and the job performs write operations (releases/tags), which is unsafe and likely to fail. Add a job-level if: github.event_name == 'push' (or move PR linting into a separate workflow) so releases only run on intended pushes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit installrelies onpre-commitbeing on PATH. Since the instructions install it via Poetry, it’s safer to either instruct users to enterpoetry shellfirst or runpoetry run pre-commit installso the command works without extra steps.