Skip to content

Fix: Node List len is reported 0x00 when LR node is inlcuded #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshithChukka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Node List len is reported 0x00 when LR node is inlcuded #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a922309
bitmask trimming by scanning from end of buffer
harshithChukka May 27, 2026
e439a9c
Correct length constant in BuildFailedNodeListFrame for LR nodes
harshithChukka May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/CC_NetworkManagement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,11 +2337,13 @@ LearnModeStatus(LEARN_INFO* inf)
* will return 2. */
uint16_t find_min_bitmask_len(uint8_t *buffer, uint16_t length)
{
uint16_t i = 0;
while((i < length) && (buffer[i] != 0)) {
i++;
while (length > 0) {
if (buffer[length - 1] != 0) {
return length;
}
length--;
}
return i;
return 0;
}

static uint16_t BuildFailedNodeListFrame(uint8_t* buffer, uint8_t seq)
Expand Down Expand Up @@ -2375,7 +2377,7 @@ static uint16_t BuildFailedNodeListFrame(uint8_t* buffer, uint8_t seq)
}
/* Calculate minimum len of failed node list bitmask that needs to be sent
* and not whole ZW_MAX_NODES/8 */
lr_len = find_min_bitmask_len(NODEMASK_GET_LR(nlist), MAX_NODEMASK_LENGTH);
lr_len = find_min_bitmask_len(NODEMASK_GET_LR(nlist), MAX_LR_NODEMASK_LENGTH);

memcpy(&f->failedNodeListData1, nlist, MAX_CLASSIC_NODEMASK_LENGTH );
f->extendedNodeidMSB = lr_len >> 8;
Expand Down