docs: correct the TrueHD Atmos CODECS levels, OS requirement and delivery state - #9
Conversation
…very state - cli.md and formats.md said `apac.31.03` covers up to 12 channels. 5.1.2 has 8 channels and `APACSampleEntry.codecsString` gives it level 2, so the master reads `apac.31.02`. DocumentedConstantsTests now pins 8, 10 and 12 channels. - api.md named "OS 25 and earlier" as a fallback case. There is no OS 25; the path needs iOS, tvOS, macOS or visionOS 26. - `.bridged` said the bed channels stay lossless. That holds for FLAC only; E-AC-3 and the APAC path are lossy. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The changes are limited to correcting APAC codec-level, OS-version, delivery-state, and rendering documentation, with guarded test assertions for the documented values. No production behavior or runtime paths are modified. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 78ae042
1 participant
Summary
Three statements about the TrueHD Atmos path did not match the code. CodeRabbit flagged the first two on #6. Stacked on #8, because both change the same
formats.mdparagraph; GitHub retargets this PR tomainwhen #8 merges.What changed
cli.mdandformats.mdsaidapac.31.03covers up to 12 channels. 5.1.2 has 8 channels, andAPACSampleEntry.codecsStringgives it level 2, so its master readsapac.31.02.DocumentedConstantsTestsnow pins 8, 10 and 12 channels.api.mdlisted "OS 25 and earlier" as a fallback case. There is no OS 25; the path needs iOS, tvOS, macOS or visionOS 26.AudioDelivery.bridgedsaid the bed channels stay lossless. That holds only for FLAC. E-AC-3 and APAC are lossy, and APAC renders the Atmos objects into the bed.Test plan
Scripts/check-doc-links.pyresolves every link, andDocumentedConstantsTests(16) andPublicAPIDocumentationTests(4) pass.Checklist
CHANGELOG.mdupdated (not needed: the changelog entry for the feature already states the OS 26 requirement and makes no claim about levels)feat(...),fix(...),chore(...))AI disclosure: written with Claude Opus 5.5 (
claude-opus-5-5) in Claude Code, from a review of #6 by Claude Opus 5.5 subagents. No other AI tooling was used.🤖 Generated with Claude Code
Note
Fix TrueHD Atmos APAC codec level, OS requirement, and delivery docs
--atmos-bedexamples in cli.md: level02for 8 channels,03for 9–12,04for 13–24.objectAudioRenderingas requiring OS 26+ on iOS, tvOS, macOS, and visionOS in api.md..bridgedAudioDeliverycase in api.md and PlayerState.swift: FLAC and E-AC-3 bridge output vs the optional APAC path that renders TrueHD Atmos objects into the speaker bed.apac.31.02or 10 channels toapac.31.03; the 12-channel assertion message changed.Macroscope summarized 78ae042.