fix(player): pick up AetherEngine's TrueHD Atmos sync fix - #494
Conversation
TrueHD Atmos played 42.7 ms ahead of the video: AetherEngine's APAC bridge dropped the encoder's 2048 frames of priming, which AVFoundation removes again on playback. Silo-Server/AetherEngine#8 keeps the priming packets. Move the pin, Package.resolved and the notices to that commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Silo-Server/AetherEngine#8 merged as a02975ed. Its tree is identical to the PR head 455bcd60 this branch pinned before, so only the recorded revision moves. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a tightly scoped dependency pin and provenance update that imports a specific TrueHD Atmos timing fix, affecting only the existing opt-in Atmos rendering path while leaving default and non-Atmos playback unchanged. The upstream correction has targeted timestamp, muxing, and AVFoundation coverage, with no broader capability, schema, infrastructure, or sensitive-area changes. You can add or adjust custom eligibility rules. Learn more. |
Problem
TrueHD Atmos played 42.7 ms ahead of the video. AetherEngine's APAC bridge dropped the encoder's 2048 frames of priming, and AVFoundation removes those frames again on playback, so every session ran early, at load and after every seek.
Solution
Silo-Server/AetherEngine#8 keeps the priming packets. This PR moves the AetherEngine pin in
project.yml,Package.resolved,THIRD_PARTY_NOTICES.mdand the bundledREADME.txtto its merge commit on the engine's main branch,a02975ed.Validation
455bcd6(CODE_SIGNING_ALLOWED=NO). The merge commita02975edhas the same source tree.Validation tasks: none. No passed v1.0 case covers TrueHD Atmos playback.
AI disclosure: written with Claude Opus 5.5 (
claude-opus-5-5) in Claude Code. No other AI tooling was used.🤖 Generated with Claude Code