Skip to content

fix(player): pick up AetherEngine's TrueHD Atmos sync fix - #494

Merged
Quick104 merged 2 commits into
mainfrom
fix/aetherengine-truehd-atmos-sync
Sep 26, 2026
Merged

Quick104 merged 2 commits into
mainfrom
fix/aetherengine-truehd-atmos-sync

Conversation

@Quick104

@Quick104 Quick104 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem

TrueHD Atmos played 42.7 ms ahead of the video. AetherEngine's APAC bridge dropped the encoder's 2048 frames of priming, and AVFoundation removes those frames again on playback, so every session ran early, at load and after every seek.

Solution

Silo-Server/AetherEngine#8 keeps the priming packets. This PR moves the AetherEngine pin in project.yml, Package.resolved, THIRD_PARTY_NOTICES.md and the bundled README.txt to its merge commit on the engine's main branch, a02975ed.

Validation

  • SiloTV builds for the tvOS Simulator against the PR head 455bcd6 (CODE_SIGNING_ALLOWED=NO). The merge commit a02975ed has the same source tree.
  • Engine side (details in AetherEngine#8): AVPlayer over HLS on macOS 27 placed a test click 42.7 ms early with the old stamping, at the start, after a seek and after a restarted encoder. With the fix it matches an ALAC reference in all three.
  • Not yet checked on Apple TV hardware. After this merges, a TestFlight build on an Apple TV into an Atmos receiver should show TrueHD Atmos titles back in lip sync.

Validation tasks: none. No passed v1.0 case covers TrueHD Atmos playback.

AI disclosure: written with Claude Opus 5.5 (claude-opus-5-5) in Claude Code. No other AI tooling was used.

🤖 Generated with Claude Code

TrueHD Atmos played 42.7 ms ahead of the video: AetherEngine's APAC bridge
dropped the encoder's 2048 frames of priming, which AVFoundation removes again
on playback. Silo-Server/AetherEngine#8 keeps the priming packets. Move the pin,
Package.resolved and the notices to that commit.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 332caba2-e407-44b7-a238-60036852bab2

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb8125 and 1b57bed.

⛔ Files ignored due to path filters (1)
  • iosApp/Silo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
📒 Files selected for processing (3)
  • THIRD_PARTY_NOTICES.md
  • iosApp/Resources/OpenSourceLicenses/README.txt
  • iosApp/project.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Silo-Server/AetherEngine#8 merged as a02975ed. Its tree is identical to the
PR head 455bcd60 this branch pinned before, so only the recorded revision moves.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Quick104
Quick104 marked this pull request as ready for review September 26, 2026 04:54
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@macroscopeapp

macroscopeapp Bot commented Sep 26, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 1b57bed

Macroscope's review found this PR approvable — This is a tightly scoped dependency pin and provenance update that imports a specific TrueHD Atmos timing fix, affecting only the existing opt-in Atmos rendering path while leaving default and non-Atmos playback unchanged. The upstream correction has targeted timestamp, muxing, and AVFoundation coverage, with no broader capability, schema, infrastructure, or sensitive-area changes.

You can add or adjust custom eligibility rules. Learn more.

@Quick104
Quick104 merged commit 2e3d6d3 into main Sep 26, 2026
6 checks passed
@Quick104
Quick104 deleted the fix/aetherengine-truehd-atmos-sync branch September 26, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant