Repository navigation
fix(player): keep a paused video paused and in place when its player item dies - #551
Conversation
…item dies Moves the AetherEngine pin to b1e4879e, which includes Silo-Server/AetherEngine#10 (the item-death reload keeps a viewer's pause) and Silo-Server/AetherEngine#11 (the media fallback returns to the recovery position and plays only for a viewer who was playing). Refs #549 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe AetherEngine package pin and its source acknowledgements now reference revision ChangesAetherEngine revision update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated engine revision and its acknowledgements are consistent, including the playback-recovery changes. No concrete merge-blocking issue remains; the change is ready for normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
On Apple TV, a paused video can start playing by itself, sometimes from the beginning (#549). A diagnostics report from an Apple TV 4K (2nd generation, tvOS 26.6, build 57) logged the full sequence:
-11868.play().The fallback went back to 0:00 because it reused the session's first start position, not the position the recovery had reloaded at.
Solution
This PR moves the AetherEngine pin from
a02975edtob1e4879e. The new revision includes:The pin changes in
project.yml,Package.resolved,THIRD_PARTY_NOTICES.mdand the bundledREADME.txt. The engine's own dependencies (FFmpegBuild, SiloObjectAudio) did not change.#549 was closed when AetherEngine#10 merged. This PR ships that fix and the rest of it in the app.
Validation
b1e4879ewithCODE_SIGNING_ALLOWED=NO. This is a compile-only check.swift testpasses on the engine for both PRs, locally and in the engine's CI. New tests cover:Validation tasks: none. No passed v1.0 case covers pausing playback.
Risks and follow-ups
AI disclosure: written with Claude Opus 5.5 (
claude-opus-5-5) in Claude Code (T3 Code). The Codex, Kody and CodeRabbit review bots reviewed the engine PRs. No other AI tooling was used.🤖 Generated with Claude Code