Skip to content

fix(people): let a clipped biography be read in full on iPhone, iPad and Mac - #697

Merged
Quick104 merged 1 commit into
Silo-Server:mainfrom
timmyconnect:fix/person-bio-more
Oct 8, 2026
Merged

Quick104 merged 1 commit into
Silo-Server:mainfrom
timmyconnect:fix/person-bio-more

Conversation

@timmyconnect

@timmyconnect timmyconnect commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: #427
Validation tasks: changes #307 C1

On iPhone and iPad, a person page cuts the biography off after eight lines and offers no way to read the rest. This change adds a More control that shows the whole biography. Apple TV has the same limit and is not covered here, so #427 stays open for it.

Approach

The biography on the shared iPhone, iPad and Mac person page is now its own small view. When eight lines cut text off, a More control appears under it; tapping the control or the text shows everything, and the control becomes Less. A biography that fits shows no control.

Whether the text is clipped is measured, not estimated from its length: the view compares the height of the eight-line text with the height of the same text at the same width and no line limit. The column width differs a lot between iPhone and iPad, so a character count would be wrong on one of them.

Apple TV is left out on purpose. A long biography is taller than the screen, so it needs a separate full-text screen with its own scrolling and a focus check on a device.

Validation

  • Rendered on the iPad Pro 11-inch (M5) simulator, iOS 26.5, against a live server: More appears on a clipped biography, expands it, and Less collapses it. Captures below.
  • iPhone width: not rendered; the iPhone simulator had no signed-in server. The view is the same code.
  • A biography short enough to fit: not rendered.
  • macOS: not built. It uses the same view.
  • No unit test added; this is a layout change.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-apple/pr-697/

Surface and build: iPad person page, same server, profile and person. Before is main at da34e44; after is this branch.

Risks

None identified. The hidden copy of the text used for measuring adds one extra text layout per person page.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • The Evidence section shows every change a user can see, or says there is none.

AI Disclosure

  • Harness: Claude Code (desktop app)
  • Tool(s): Xcode xcodebuild, simctl, iOS Simulator, GitHub CLI, @silo-server/evidence
  • Model(s): claude-opus-5-5
  • Involvement: AI-authored; not yet reviewed by a human
  • Adversarial review: n/a

🤖 Generated with Claude Code

@silo-kody

silo-kody Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 04e8a29b-fef0-4958-a000-c15d90f6420d
📥 Commits

Reviewing files that changed from the base of the PR and between 7af0d58 and 74f7f8a.

📒 Files selected for processing (1)
  • iosApp/iosApp/Screens/People/PersonDetailView.swift
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Quick104 Quick104 added priority: P2 Limited scope, workaround exists, or polish impact: polish Annoyance, cosmetic, or nice-to-have labels Oct 8, 2026 — with Cursor
…and Mac

The person page cut the biography at eight lines with no way to read the
rest. A More control now appears when the text is clipped; it, or a tap
on the text, shows the whole biography. Short biographies show no control.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-kody

silo-kody Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@Quick104
Quick104 merged commit 8619745 into Silo-Server:main Oct 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants