Repository navigation
fix(people): let a clipped biography be read in full on iPhone, iPad and Mac - #697
Conversation
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…and Mac The person page cut the biography at eight lines with no way to read the rest. A More control now appears when the text is clipped; it, or a tap on the text, shows the whole biography. Short biographies show no control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1ca359d to
74f7f8a
Compare
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Problem
Related issue: #427
Validation tasks: changes #307 C1
On iPhone and iPad, a person page cuts the biography off after eight lines and offers no way to read the rest. This change adds a More control that shows the whole biography. Apple TV has the same limit and is not covered here, so #427 stays open for it.
Approach
The biography on the shared iPhone, iPad and Mac person page is now its own small view. When eight lines cut text off, a More control appears under it; tapping the control or the text shows everything, and the control becomes Less. A biography that fits shows no control.
Whether the text is clipped is measured, not estimated from its length: the view compares the height of the eight-line text with the height of the same text at the same width and no line limit. The column width differs a lot between iPhone and iPad, so a character count would be wrong on one of them.
Apple TV is left out on purpose. A long biography is taller than the screen, so it needs a separate full-text screen with its own scrolling and a focus check on a device.
Validation
Evidence
Evidence: https://evidence.siloserver.org/r/silo-apple/pr-697/
Surface and build: iPad person page, same server, profile and person. Before is
mainat da34e44; after is this branch.Risks
None identified. The hidden copy of the text used for measuring adds one extra text layout per person page.
Checklist
AI Disclosure
xcodebuild,simctl, iOS Simulator, GitHub CLI,@silo-server/evidence🤖 Generated with Claude Code