chore(deps): update the plugin SDK for rating sync - #10
Conversation
The catalog decodes plugin manifests with the SDK it pins and discards fields it does not know. On v0.13.2 it would drop the watch-sync rating flags and the series media type from a plugin release, and the catalog entry would then advertise a plugin without them. Update to the SDK commit that adds them; bump to the v0.17.0 tag once it is released. Every existing catalog entry that validates on v0.13.2 still validates. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Quick104 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe module requirements update the Silo Plugin SDK and five indirect dependencies. The explicit protobuf requirement remains unchanged. ChangesModule dependencies
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established for this dependency update; normal build and test checks remain appropriate. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Problem
Related issue: N/A
Validation tasks: none
The catalog decodes plugin manifests with the SDK it pins, discarding fields it doesn't know. On v0.13.2 it would drop the new watch-sync rating flags and the series media type from a plugin release, so the catalog entry would advertise the plugin without them.
Approach
Update the SDK to the commit that adds the rating contract (Silo-Server/silo-plugin-sdk#23), and bump to the v0.17.0 tag once it's released. This has to land before the catalog ingests a plugin release that uses ratings.
Validation
go build ./...andgo test ./...pass.ValidateCatalogPresentation. All pass exceptsilo.requests.arrandsilo.requests.seerr, which lack a presentation block and fail the same way on v0.13.2. Ingestion validates only the plugin being released, so they're unaffected.Risks
This moves the validator across SDK v0.14–v0.16. The stricter rules apply only to future ingestion, and they pass for every existing entry except the two above.
Checklist
AI Disclosure
🤖 Generated with Claude Code
Summary by CodeRabbit