Skip to content

chore(deps): update the plugin SDK for rating sync - #10

Merged
Quick104 merged 2 commits into
mainfrom
chore/sdk-watchsync-ratings
Sep 24, 2026
Merged

Quick104 merged 2 commits into
mainfrom
chore/sdk-watchsync-ratings

Conversation

@Quick104

@Quick104 Quick104 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

The catalog decodes plugin manifests with the SDK it pins, discarding fields it doesn't know. On v0.13.2 it would drop the new watch-sync rating flags and the series media type from a plugin release, so the catalog entry would advertise the plugin without them.

Approach

Update the SDK to the commit that adds the rating contract (Silo-Server/silo-plugin-sdk#23), and bump to the v0.17.0 tag once it's released. This has to land before the catalog ingests a plugin release that uses ratings.

Validation

  • go build ./... and go test ./... pass.
  • Every existing catalog entry was re-validated with the new SDK's ValidateCatalogPresentation. All pass except silo.requests.arr and silo.requests.seerr, which lack a presentation block and fail the same way on v0.13.2. Ingestion validates only the plugin being released, so they're unaffected.

Risks

This moves the validator across SDK v0.14–v0.16. The stricter rules apply only to future ingestion, and they pass for every existing entry except the two above.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code subagents
  • Model(s): claude-opus-5-5
  • Involvement: Fully AI-generated; the maintainer set scope and product decisions. Human review of the diff is pending.
  • Adversarial review: n/a (dependency update; every existing catalog entry was re-validated with the new SDK).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the Silo Plugin SDK and supporting components to newer versions, keeping the app’s underlying integrations current. These updates do not change the app’s features or how it works for users.

The catalog decodes plugin manifests with the SDK it pins and discards
fields it does not know. On v0.13.2 it would drop the watch-sync rating
flags and the series media type from a plugin release, and the catalog
entry would then advertise a plugin without them. Update to the SDK
commit that adds them; bump to the v0.17.0 tag once it is released.

Every existing catalog entry that validates on v0.13.2 still validates.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick104 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T01:08:55.341414Z 870ffd0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 39ba5fff-f364-4705-a82a-15105a3648e0

📥 Commits

Reviewing files that changed from the base of the PR and between 870ffd0 and 4ba39b9.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
 ___________________________________________________________________
< Your commit message says 'quick fix'. That's how folklore starts. >
 -------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2890b71a-a83b-423d-b005-ca558953cb58

📥 Commits

Reviewing files that changed from the base of the PR and between dd94999 and 870ffd0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The module requirements update the Silo Plugin SDK and five indirect dependencies. The explicit protobuf requirement remains unchanged.

Changes

Module dependencies

Layer / File(s) Summary
Update module dependency versions
go.mod
The Silo Plugin SDK and five indirect dependencies use newer versions. The protobuf requirement is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 870ff

No actionable merge-blocking issue is established for this dependency update; normal build and test checks remain appropriate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the plugin SDK to support rating synchronization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Quick104
Quick104 merged commit 56d192b into main Sep 24, 2026
2 of 3 checks passed
@Quick104
Quick104 deleted the chore/sdk-watchsync-ratings branch September 24, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant