Skip to content

chore(deps): update the plugin SDK for dropped shows and rating gates - #14

Merged
Quick104 merged 1 commit into
mainfrom
chore/sdk-v0.21-watch-providers
Oct 2, 2026
Merged

Quick104 merged 1 commit into
mainfrom
chore/sdk-v0.21-watch-providers

Conversation

@Quick104

@Quick104 Quick104 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none
Used by: the first-party Trakt, Simkl, and MDBList watch-provider plugins (Silo-Server/silo-plugin-watchprovider-trakt, -simkl, -mdblist), and Silo-Server/silo-plugin-sdk#33.

The catalog decodes plugin manifests with the SDK it pins and discards fields it doesn't know. On v0.17.0 it would drop sync_dropped and rating_export_requires_watched from the new Trakt and Simkl releases, so their catalog entries would leave out dropped-show sync and Simkl's movie-rating gate.

Approach

Update the SDK to v0.21.0, which adds those fields. This has to land before the catalog ingests the first watch-provider plugin releases.

Validation

  • go build ./... and go test ./... pass.
  • Building catalog packages from the three plugins' 0.2.0 manifests with BuildPackageFromRelease keeps sync_dropped (Trakt, Simkl) and the movie rating gate (Simkl), and the results pass manifest.Validate.
  • Every existing catalog entry gives the same ValidateCatalogPresentation result on v0.17.0 and v0.21.0. All pass except silo.requests.arr and silo.requests.seerr, which lack a presentation block on both versions.

Risks

None expected: v0.18–v0.21 add contract fields only, and ingestion validates just the plugin being released.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code subagents
  • Model(s): claude-opus-5-5
  • Involvement: Fully AI-generated; the maintainer set scope and product decisions. Human review of the diff is pending.
  • Adversarial review: n/a (dependency update; existing entries re-validated with the new SDK).

🤖 Generated with Claude Code

Note

Update silo-plugin-sdk from v0.17.0 to v0.21.0

Bumps github.com/Silo-Server/silo-plugin-sdk to v0.21.0 in go.mod, with matching checksums in go.sum. The SDK update covers dropped shows and rating gates.

Macroscope summarized 6bd77c6.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T15:31:14.780878Z 6bd77c6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d2ac5975-3eff-4a7d-bc96-c87a22b80f23

📥 Commits

Reviewing files that changed from the base of the PR and between 9221cd2 and 6bd77c6.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The required version of github.com/Silo-Server/silo-plugin-sdk changes from v0.17.0 to v0.21.0 in go.mod.

Changes

SDK dependency

Layer / File(s) Summary
Update SDK version
go.mod
The required github.com/Silo-Server/silo-plugin-sdk version changes from v0.17.0 to v0.21.0.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6bd77

The SDK upgrade preserves the watch-provider fields through catalog ingestion, with no concrete merge-blocking issue identified. Build and test results remain to be confirmed by CI; the PR reports they pass.

Architecture Summary

Architecture risk: 🔵 Low · up to 6bd77

The change affects 1 system.

Changed systems: go.mod

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — go.mod (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in go.mod: The required github.com/Silo-Server/silo-plugin-sdk version changes from v0.17.0 to v0.21.0.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency update and its purpose: supporting dropped-show synchronization and rating gates.
Description check ✅ Passed The description directly explains the SDK update, the affected manifest fields, validation results, and intended outcome.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Quick104
Quick104 merged commit 74c4cff into main Oct 2, 2026
3 checks passed
@Quick104
Quick104 deleted the chore/sdk-v0.21-watch-providers branch October 2, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant