Skip to content

fix(web): rename admin Home rows back to Sections - #2106

Merged
Quick104 merged 1 commit into
mainfrom
fix/revert-home-rows-rename
Oct 8, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/revert-home-rows-rename

Conversation

@Quick104

@Quick104 Quick104 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: #1877
Validation tasks: changes #1141 C1 (not yet run)

#1877 renamed the admin page that sets the shared Home and library-page rows from Sections to Home rows and moved it to /admin/home-rows. Maintainers want the old name back. This puts the page back at /admin/sections as Sections and keeps /admin/home-rows working as a redirect. That address has been on main since #1877 but is in no release tag.

Approach

  • /admin/sections serves the page again. /admin/home-rows redirects there and keeps ?page= and the hash, just as the reverse redirect did before.
  • The heading, sidebar item, command-palette entry, tab title ("Admin Sections"), the "Manage sections" link on library pages and the copy that names the page all say Sections again. The old name stays as a search keyword.
  • "Row" is still the word for one entry on the page ("Add row", "23 rows · 23 on"). Only the page name changes back.
  • Internal names (HomeRowsPage, lib/homeRows) and Settings > Home Screen are unchanged.
  • docs/architecture/collection-editor.md names the route again.

#1141 C1 builds rows "entirely through web admin". That case hasn't run yet, but its steps now start at Sections.

Validation

  • Web: make test-web passes (834 files). tsc, ESLint (0 errors), Prettier, build and bundle budget pass. The bundle grows 167 B brotli, inside the budget's slack.
  • Repo checks: route inventory, offline routes, case collisions and local paths pass.
  • Go: not run, no Go changes.
  • Manual, against a dev server, compared with main:
    • /admin/sections stays put with the title "Admin Sections · Silo".
    • /admin/home-rows?page=home lands on /admin/sections?page=home.
    • Phone layout is unchanged.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/pr-2106/

Surface and build: web admin, desktop and phone width, this branch compared with main at f5f0f54.

Risks

Bookmarks to /admin/home-rows keep working through the redirect. The manual's main branch doesn't name the admin page. The open manual PR Silo-Server/siloserver.org#122 says "Admin > Home rows" and needs a matching edit before it merges.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • The Evidence section shows every change a user can see, or says there is none.

AI Disclosure

  • Harness: Claude Code, running in T3 Code
  • Tool(s): Claude Code, Playwright (captures)
  • Model(s): claude-opus-5-5[1m]
  • Involvement: Fully AI-generated, at a maintainer's request; the maintainer has not yet reviewed the diff
  • Adversarial review: n/a

🤖 Generated with Claude Code

Note

Rename admin Home rows route to Sections with legacy redirect

Makes /admin/sections the canonical route for the admin Home rows page. The old /admin/home-rows URL now renders a new redirect component (LegacyAdminHomeRowsRedirect.tsx) that forwards query string and hash to the Sections path and replaces the history entry. The previous reverse redirect (LegacyAdminSectionsRedirect.tsx) is removed.

  • Updates user-facing copy from "Home rows" to "Sections" or generic "rows" wording across AdminHomeRows.tsx, copy.ts, notes.tsx, and other pages.
  • Renames the sidebar nav item in adminNavigation.ts and aligns the document-title map in documentTitle.ts.
  • Behavioral Change: admin row links generated by homeRows.HOME_ROWS_PATHS in rowLinks.ts now point to /admin/sections; conflict and restore banners use page-agnostic wording instead of mentioning Home rows.

Macroscope summarized 33a2868.

Admin > Home rows returns to its earlier name, Sections, at
/admin/sections. /admin/home-rows, used since #1877, now redirects there
and keeps ?page= and the hash. Copy that named the page follows; "row"
stays the word for one row on it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T16:16:09.861083Z 33a2868 PR opened
🔒 Security Review ✅ Completed 2026-10-08T16:17:17.262615Z 33a2868 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@Quick104 Quick104 added priority: P2 Limited scope, workaround exists, or polish impact: usability Core flow broken or severely blocked impact: polish Annoyance, cosmetic, or nice-to-have and removed impact: usability Core flow broken or severely blocked labels Oct 8, 2026 — with Cursor
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e823146-b35d-48f3-90e6-5f24e22a9cd1
📥 Commits

Reviewing files that changed from the base of the PR and between f5f0f54 and 33a2868.

📒 Files selected for processing (36)
  • docs/architecture/collection-editor.md
  • web/src/App.adminRoutes.test.tsx
  • web/src/App.tsx
  • web/src/components/AdminLayout.test.tsx
  • web/src/components/AdminSidebar.test.tsx
  • web/src/components/collections/StarterPacksDialog.test.tsx
  • web/src/components/collections/StarterPacksDialog.tsx
  • web/src/components/homeRows/HomeRowsPage.test.tsx
  • web/src/components/homeRows/RestoreDialog.test.tsx
  • web/src/components/homeRows/RestoreDialog.tsx
  • web/src/components/homeRows/notes.tsx
  • web/src/hooks/queries/homeRows/useAdminHomeRows.test.tsx
  • web/src/lib/adminNavigation.test.ts
  • web/src/lib/adminNavigation.ts
  • web/src/lib/collections/copy.test.ts
  • web/src/lib/collections/copy.ts
  • web/src/lib/collections/rows.test.ts
  • web/src/lib/documentTitle.test.ts
  • web/src/lib/documentTitle.ts
  • web/src/lib/homeRows/rowLinks.test.ts
  • web/src/lib/homeRows/rowLinks.ts
  • web/src/pages/AdminCollections.list.test.tsx
  • web/src/pages/AdminCollections.tsx
  • web/src/pages/AdminHomeRows.addRow.test.tsx
  • web/src/pages/AdminHomeRows.concurrency.test.tsx
  • web/src/pages/AdminHomeRows.libraryCopies.test.tsx
  • web/src/pages/AdminHomeRows.links.test.tsx
  • web/src/pages/AdminHomeRows.peeks.test.tsx
  • web/src/pages/AdminHomeRows.tsx
  • web/src/pages/CollectionEditorPage.whereItShows.test.tsx
  • web/src/pages/Collections.cards.test.tsx
  • web/src/pages/LegacyAdminHomeRowsRedirect.test.tsx
  • web/src/pages/LegacyAdminHomeRowsRedirect.tsx
  • web/src/pages/LegacyAdminSectionsRedirect.tsx
  • web/src/pages/LibraryRecommended.test.tsx
  • web/src/pages/LibraryRecommended.tsx
 __________________________________________________________________
< Series-B funding secured. Now, I can afford to review your code. >
 ------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Oct 8, 2026

Copy link
Copy Markdown

The Evidence section says evidence is “to follow” but does not link to published captures, so these visible changes are not yet evidenced:

  • Admin page title, heading, sidebar/command-palette links, and /admin/sections route with the /admin/home-rows redirect (web/src/App.tsx, web/src/pages/AdminHomeRows.tsx, web/src/lib/adminNavigation.ts): add before-and-after captures of the relevant admin screens at desktop and phone widths, including the redirect destination.
  • Changed user-facing copy in the admin collections subtitle, Starter Packs message, collection-sharing consequence, and row conflict/restore states (web/src/pages/AdminCollections.tsx, web/src/components/collections/StarterPacksDialog.tsx, web/src/lib/collections/copy.ts, web/src/components/homeRows/notes.tsx, web/src/components/homeRows/RestoreDialog.tsx): add before-and-after captures of the affected screens at desktop and phone widths.
  • The library empty-state action now says “Manage sections” and links to /admin/sections (web/src/pages/LibraryRecommended.tsx): add before-and-after captures of that same screen at desktop and phone widths.

Suggested fix: publish the matching captures and replace the placeholder with the Evidence: https://evidence.siloserver.org/r/silo-server/pr-2106/ link.

Automated check: Macroscope check run agent (gpt-6-luna). Evidence was not reviewed for correctness.

Posted via Macroscope — Visible change evidence

@Quick104
Quick104 merged commit 3bfe96f into main Oct 8, 2026
17 of 19 checks passed
@Quick104
Quick104 deleted the fix/revert-home-rows-rename branch October 8, 2026 16:17
@macroscopeapp

macroscopeapp Bot commented Oct 8, 2026

Copy link
Copy Markdown

The Validation tasks: line omits #1141 C2. C2 changes the centrally defined row set through the web-admin builder before checking client refresh, so this route/title rename changes its entry point as well as C1's. Both cases are currently Not run; no recorded result is being invalidated. Please update the line to:

Validation tasks: changes #1141 C1, C2 (entry-point label and route only; not yet run)

Automated check: Macroscope check run agent (gpt-6-luna). No validation was performed.

Posted via Macroscope — v1 validation impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant