Skip to content

docs(subtitles): describe in-stream subtitles on converted playback - #229

Open
Rhainland wants to merge 1 commit into
Silo-Server:mainfrom
Rhainland:feat/hls-subtitle-renditions
Open

Rhainland wants to merge 1 commit into
Silo-Server:mainfrom
Rhainland:feat/hls-subtitle-renditions

Conversation

@Rhainland

@Rhainland Rhainland commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A. Manual update for Silo-Server/silo-server#2620.

With Silo-Server/silo-server#2620, Silo puts a text subtitle from inside a video file into the converted stream on the Apple and Android apps, so it no longer waits for a separate download. The manual doesn't say that switching to another such subtitle restarts the converted stream. It also doesn't say that an older transcode node can't do this and falls back to the slower download.

Pages changed

Page Change Preview
Subtitles New paragraph on subtitles carried in the converted stream Open
Transcode nodes New paragraph on older nodes and in-stream subtitles Open

What changed on each page

Subtitles

  • After the paragraph on choosing Off: when Silo converts the video, the Apple and Android apps get a text subtitle from inside the file as part of the stream, so it shows from the first scene. Choosing another one restarts the converted stream at the same spot.

Transcode nodes

  • At the end of the page: a node on an older Silo version still converts video but can't put those subtitles in the stream, so the apps download them separately and they can be slow on network storage. Update every transcode node.

Decisions for review

Evidence

Source reviewed against the three code PRs. No device test of the pages.

bun run test:docs   ℹ tests 8  ℹ pass 8  ℹ fail 0
bun run build       All internal links are valid; [build] Complete!
git diff --check    clean

(Bun ran through npx bun@1, with install --frozen-lockfile first.)

Risks

None identified. Documentation only.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code; Codex CLI for review
  • Model(s): claude-opus-5-5 (writing and review); gpt-6.1-sol (review)
  • Involvement: Fully AI-generated, human verified
  • Adversarial review: two independent reviews (claude-opus-5-5 and gpt-6.1-sol) of the diff found no defects.

Note

Document in-stream subtitles on converted playback

Adds docs covering embedded subtitle behavior when Silo converts video for devices.

  • subtitles.md explains that Apple and Android apps get text subtitles from inside the video file as part of the converted stream, and that switching embedded subtitles restarts conversion at the same playback position.
  • transcode-nodes.md explains that older transcode nodes cannot embed in-file subtitles, that apps download them separately, and that network storage can delay their appearance. It recommends updating every transcode node.

Macroscope summarized 22f5abe.

Text subtitles inside a video file now reach the Silo apps as part of a converted stream, and choosing another one restarts that stream at the same spot. Transcode nodes on an older version still convert video but leave those subtitles to a separate, slower download.
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Oct 17, 2026
@silo-kody

silo-kody Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌
⚠️ 2 Kody Rule(s) were not evaluated

These rules declare that they need repository context beyond this diff, and the review could not retrieve it, so they were not judged on this pull request:

  • Scope polling setup steps to installable source capabilities
  • Preserve retired documentation URLs with tested redirects

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03e2ed0c-9c39-4df1-9001-f34f23c59331
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@silo-triage silo-triage Bot added the documentation Improvements or additions to documentation label Oct 17, 2026
@github-actions

Copy link
Copy Markdown

Preview deployed: https://pr-229.siloserver-org.pages.dev

Commit 22f5abe

Docs changes: 2 changes on 2 pages. Each link opens the first change on its page. Step through the rest with the changes box in the corner of the preview.

Page Changes
Choose and adjust subtitles 1
Add and check transcode nodes 1

The alias updates after a successful build and deployment. The preview is removed when this pull request closes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant