Repository navigation
Conversation
Text subtitles inside a video file now reach the Silo apps as part of a converted stream, and choosing another one restarts that stream at the same spot. Transcode nodes on an older version still convert video but leave those subtitles to a separate, slower download.
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployed: https://pr-229.siloserver-org.pages.dev
Docs changes: 2 changes on 2 pages. Each link opens the first change on its page. Step through the rest with the changes box in the corner of the preview.
The alias updates after a successful build and deployment. The preview is removed when this pull request closes. |
Problem
Related issue: N/A. Manual update for Silo-Server/silo-server#2620.
With Silo-Server/silo-server#2620, Silo puts a text subtitle from inside a video file into the converted stream on the Apple and Android apps, so it no longer waits for a separate download. The manual doesn't say that switching to another such subtitle restarts the converted stream. It also doesn't say that an older transcode node can't do this and falls back to the slower download.
Pages changed
What changed on each page
Subtitles
Transcode nodes
Decisions for review
src/data/docs-release.mjsis unchanged, because it records a review of the whole manual.Evidence
Source reviewed against the three code PRs. No device test of the pages.
(Bun ran through
npx bun@1, withinstall --frozen-lockfilefirst.)Risks
None identified. Documentation only.
Checklist
AI Disclosure
Note
Document in-stream subtitles on converted playback
Adds docs covering embedded subtitle behavior when Silo converts video for devices.
Macroscope summarized 22f5abe.