Conversation
Contributor
Author
mrp089
approved these changes
Feb 10, 2025
Member
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
This looks great! We can use your way of combining several unit tests for svMultiPhysics, too.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CPP unit tests
Current situation
We're looking to add support for JSON input files.
Add support for JSON input files
There's currently a Windows build failure.
Windows build fails #115
Release Notes
This change initiates CPP unit testing so we can more robustly migrate to the JSON serializer while continuing to support the legacy format.
Documentation
There are no functional changes, so no documentation needs to be added.
Testing
No new code. Unit Tests have been added to legacy code.
Code of Conduct & Contributing Guidelines