[FIX] account_invoice_triple_discount: restore original discount field's precision by using change_digit function#1
Conversation
| # so let's increase it just for saving it correctly in cache | ||
| discount_field = self._fields['discount'] | ||
| discount_original_digits = discount_field._digits | ||
| discount_original_digits = dp.get_precision("Discount")(self.env.cr) |
There was a problem hiding this comment.
I think you can avoid this variable discount_original_digits... just assign dp.get_precision("Discount")(self.env.cr) in
…ion in order to avoid to have always (16, 10) as precision in case of any errors.
tafaRU
force-pushed
the
12.0-fix-account_invoice_triple_discount-subtotal_computation_digits
branch
from
475829f to
8aa2657
Compare
SimoRubi
left a comment
SimoRubi
left a comment
There was a problem hiding this comment.
Can you add a test case for the errors you mentioned in the PR description?
I don't see how previous code could fail more than the one you are proposing here
|
|
||
| # Restore discount field's precision | ||
| discount_field._digits = discount_original_digits | ||
| discount_field._digits = dp.get_precision("Discount")(self.env.cr) |
There was a problem hiding this comment.
Here you are hardcoding 'Discount' precision for the field while previous code restored the original precision of the field.
How is this taking care of errors more than previous code?
|
@SimoRubi have you seen SimoRubi/sale-workflow#1 (comment) ? |
yes, but I don't think that changes the status of that PR |
3 participants
Use change_digit function to restore original discount field's precision in order to avoid to have always (16, 10) as precision in case of any errors.