Add pseudo_count to log2_FC so zero mean genes don't break fold changes#9
Open
mertcan-demir wants to merge 1 commit into
Open
Add pseudo_count to log2_FC so zero mean genes don't break fold changes#9mertcan-demir wants to merge 1 commit into
mertcan-demir wants to merge 1 commit into
Conversation
Owner
|
Hi Mert, thanks a lot for spotting this issue and informing us! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First time contributing, so please let me know if I missed anything. I noticed
log2_FC()throwsInfwhen one group has zero mean expression. So I added apseudo_countparameter as a quick fix. The default is0so nothing changes. Not sure if this is the best way to handle it (maybe preprocessing the assay is cleaner like proportional constants as edgeR do with prior.count?), but it solved the issue on my end without touching themean_*columns. Happy to adjust if you prefer a different approach! Changes are only inR/log2_FC.Rone new param + validation + a one-liner in the FC calculation.