fix(vault-sync): validate pairing device IDs

[AnkushMalaker]

Summary

• validate vault-sync pairing IDs as canonical Syncthing device IDs
• reject malformed IDs before they are interpolated into Syncthing REST paths
• move the request model into the backend models package and add focused regression tests

History

The vault-sync implementation is already committed and present on dev. The macOS client and server broker landed through the June vault-sync commits included in merged PR #332. This is a small hardening follow-up discovered while reviewing that code.

Testing

• uv run --group test pytest tests/test_vault_sync_routes.py
• uv run black --check src/advanced_omi_backend/models/vault_sync.py src/advanced_omi_backend/routers/modules/vault_sync_routes.py tests/test_vault_sync_routes.py
• uv run isort --check-only src/advanced_omi_backend/models/vault_sync.py src/advanced_omi_backend/routers/modules/vault_sync_routes.py tests/test_vault_sync_routes.py
• pre-commit and pre-push hooks

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c592c4b-5760-4588-aab9-a741bc538d81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/vault-sync-device-id-validation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

⚠️ Robot Framework Test Results (No API Keys)

Status: ❌ Some tests failed

ℹ️ Note: This run excludes tests requiring external API keys (Deepgram, OpenAI).
Tests tagged with requires-api-keys will run on dev/main branches.

Metric	Count
✅ Passed	108
❌ Failed	22
📊 Total	130

📊 View Reports

GitHub Pages (Live Reports):

• 📋 Test Report
• 📝 Detailed Log

Download Artifacts:

• robot-test-reports-html-no-api - HTML reports
• robot-test-results-xml-no-api - XML output

---

View full workflow run